From kde-panel-devel Thu May 31 13:54:52 2012 From: "Greg T" Date: Thu, 31 May 2012 13:54:52 +0000 To: kde-panel-devel Subject: Re: Review Request: Bug Marble globe wallpaper, reversed spin direction Message-Id: <20120531135452.16212.70078 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133847268431348 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0232883051560985053==" --===============0232883051560985053== Content-Type: multipart/alternative; boundary="===============5005944499165075306==" --===============5005944499165075306== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On May 31, 2012, 1:08 p.m., Dennis Nienh=C3=BCser wrote: > > Polarity determines whether north is visible top or bottom, so I don't = know why the original code was there. > > = > > I think you can even strip it down further to a simple = > > qreal const direction =3D polarity < 0 ? -1 : 1; > > = > > i.e. ignore the projection -- in non-spherical case polarity is 1. > > = > > Note that your patch also fixes bug 216156. You could use zoomIn()/zoom= Out() though instead of the hard-coded +/- 40. Thanks for clarification. I could not find zoomIn/Out in MarbleMap. Unfortu= nately this plasma wallpaper doesn't use MarbleWidget. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105118/#review14296 ----------------------------------------------------------- On May 31, 2012, 12:52 p.m., Greg T wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105118/ > ----------------------------------------------------------- > = > (Updated May 31, 2012, 12:52 p.m.) > = > = > Review request for Marble and Plasma. > = > = > Description > ------- > = > I had to delete a bunch of code to fix the issue. But what was the purpos= e of this code? Am I missing some cornercase? > = > = > This addresses bug 264755. > http://bugs.kde.org/show_bug.cgi?id=3D264755 > = > = > Diffs > ----- > = > wallpapers/marble/marble.cpp 988a8b6 = > = > Diff: http://git.reviewboard.kde.org/r/105118/diff/ > = > = > Testing > ------- > = > bug fixed. > = > = > Thanks, > = > Greg T > = > --===============5005944499165075306== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105118/

On May 31st, 2012, 1:08 p.m., Dennis Nienh= =C3=BCser wrote:

Polarity =
determines whether north is visible top or bottom, so I don't know why =
the original code was there.

I think you can even strip it down further to a simple =

qreal const direction =3D polarity < 0 ? -1 : 1;

i.e. ignore the projection -- in non-spherical case polarity is 1.

Note that your patch also fixes bug 216156. You could use zoomIn()/zoomOut(=
) though instead of the hard-coded +/- 40.
Thanks for =
clarification. I could not find zoomIn/Out in MarbleMap. Unfortunately this=
 plasma wallpaper doesn't use MarbleWidget.

- Greg


On May 31st, 2012, 12:52 p.m., Greg T wrote:

Review request for Marble and Plasma.
By Greg T.

Updated May 31, 2012, 12:52 p.m.

Descripti= on 

I had to delete a bunch of code to fix the issue. But what w=
as the purpose of this code? Am I missing some cornercase?

Testing <= /h1> 
bug fixed.
Bugs: 264755

Diffs=

  • wallpapers/marble/marble.cpp (988a8b6)

View Diff
--===============5005944499165075306==-- --===============0232883051560985053== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0232883051560985053==--