'Re: Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2012-05-30 17:33:21
Message-ID: 20120530173321.13308.3470 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/
-----------------------------------------------------------

(Updated May 30, 2012, 5:33 p.m.)

Review request for Plasma, Sebastian K=C3=BCgler and Aaron J. Seigo.

Changes
-------

I have updated the diff according to Aaron's suggestions.

Description
-------

Hello,

right now when "Enable signing plasmoid" is enabled if the user doesn't cho=
ose a gpg key,
plasmate won't have a key enabled. So "Enable signing plasmoid", will be en=
abled but no signing will
happen. =

How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable

Diffs (updated)
-----

  publisher/signingwidget.h 501752e =

  publisher/signingwidget.cpp e63dbbd =

Diff: http://git.reviewboard.kde.org/r/105074/diff/

Testing
-------

It works.

Thanks,

Giorgos Tsiapaliwkas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105074/">http://git.reviewboard.kde.org/r/105074/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated May 30, 2012, 5:33 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have updated the diff according to Aaron&#39;s suggestions.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

right now when &quot;Enable signing plasmoid&quot; is enabled if the user doesn&#39;t \
choose a gpg key, plasmate won&#39;t have a key enabled. So &quot;Enable signing \
plasmoid&quot;, will be enabled but no signing will happen. 

How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>publisher/signingwidget.h <span style="color: grey">(501752e)</span></li>

 <li>publisher/signingwidget.cpp <span style="color: grey">(e63dbbd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105074/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 