From kde-panel-devel Wed May 30 17:33:21 2012 From: "Giorgos Tsiapaliwkas" Date: Wed, 30 May 2012 17:33:21 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key Message-Id: <20120530173321.13308.3470 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133839940406768 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0419161502003479370==" --===============0419161502003479370== Content-Type: multipart/alternative; boundary="===============4065496941878193687==" --===============4065496941878193687== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105074/ ----------------------------------------------------------- (Updated May 30, 2012, 5:33 p.m.) Review request for Plasma, Sebastian K=C3=BCgler and Aaron J. Seigo. Changes ------- I have updated the diff according to Aaron's suggestions. Description ------- Hello, right now when "Enable signing plasmoid" is enabled if the user doesn't cho= ose a gpg key, plasmate won't have a key enabled. So "Enable signing plasmoid", will be en= abled but no signing will happen. = How to test the issue, - rm ${KDEHOME}/share/config/plasmaterc -create a gpg key(gpg --gen-key) -open plasmate -click publisher -click enable Diffs (updated) ----- publisher/signingwidget.h 501752e = publisher/signingwidget.cpp e63dbbd = Diff: http://git.reviewboard.kde.org/r/105074/diff/ Testing ------- It works. Thanks, Giorgos Tsiapaliwkas --===============4065496941878193687== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105074/

Review request for Plasma, Sebastian K=C3=BCgler and Aaron J. Seigo.
By Giorgos Tsiapaliwkas.

Updated May 30, 2012, 5:33 p.m.

Changes 
I have updated the diff according to Aaron's suggestions=
.

Descripti= on 

Hello,

right now when "Enable signing plasmoid" is enabled if the user d=
oesn't choose a gpg key,
plasmate won't have a key enabled. So "Enable signing plasmoid&quo=
t;, will be enabled but no signing will
happen. =


How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable

Testing <= /h1> 
It works.

Diffs= (updated)

  • publisher/signingwidget.h (501752e)=
  • publisher/signingwidget.cpp (e63dbbd)

View Diff
--===============4065496941878193687==-- --===============0419161502003479370== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0419161502003479370==--