[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: when "Enable signing plasmoid" is enabled, automatically choose a key
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-05-29 10:25:31
Message-ID: 20120529102531.19720.31849 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 28, 2012, 1:09 p.m., Aaron J. Seigo wrote:
> > given that this is a security feature, this looks a little too dangerou=
s and lose.
> > =
> > instead, disable the signing button altogether until there is at least =
one key selected.
> =
> Giorgos Tsiapaliwkas wrote:
> I don't understand In which widget you are referring. =
> Do you mean the "Enable signing plasmoid" radiobutton?
>
there are a number of ways of doing this. in fact, thinking about it: i'd g=
et rid of the "Enable signing" checkbox altogether. always make the signing=
UI enabled and if a key is selected, use that key. to allow selecting a ke=
y and then going back to "no signing" perhaps have a "No signing key" entry=
at the top of the key entry area. makes the whole thing a lot easier and g=
ets rid of one more widget (the checkbox) in an already pretty busy window
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/#review14229
-----------------------------------------------------------
On May 28, 2012, 8:01 a.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105074/
> -----------------------------------------------------------
> =
> (Updated May 28, 2012, 8:01 a.m.)
> =
> =
> Review request for Plasma, Sebastian K=C3=BCgler and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> Hello,
> =
> right now when "Enable signing plasmoid" is enabled if the user doesn't c=
hoose a gpg key,
> plasmate won't have a key enabled. So "Enable signing plasmoid", will be =
enabled but no signing will
> happen. =
> =
> How to test the issue,
> - rm ${KDEHOME}/share/config/plasmaterc
> -create a gpg key(gpg --gen-key)
> -open plasmate
> -click publisher
> -click enable
> =
> =
> Diffs
> -----
> =
> publisher/signingwidget.cpp e63dbbd =
> =
> Diff: http://git.reviewboard.kde.org/r/105074/diff/
> =
> =
> Testing
> -------
> =
> It works.
> =
> =
> Thanks,
> =
> Giorgos Tsiapaliwkas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105074/">http://git.reviewboard.kde.org/r/105074/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 28th, 2012, 1:09 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">given that this is a security feature, this looks a little too dangerous \
and lose.
instead, disable the signing button altogether until there is at least one key \
selected.</pre> </blockquote>
<p>On May 28th, 2012, 4:25 p.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand \
In which widget you are referring. Do you mean the "Enable signing \
plasmoid" radiobutton? </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there are a number of \
ways of doing this. in fact, thinking about it: i'd get rid of the "Enable \
signing" checkbox altogether. always make the signing UI enabled and if a key is \
selected, use that key. to allow selecting a key and then going back to "no \
signing" perhaps have a "No signing key" entry at the top of the key \
entry area. makes the whole thing a lot easier and gets rid of one more widget (the \
checkbox) in an already pretty busy window</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On May 28th, 2012, 8:01 a.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated May 28, 2012, 8:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
right now when "Enable signing plasmoid" is enabled if the user doesn't \
choose a gpg key, plasmate won't have a key enabled. So "Enable signing \
plasmoid", will be enabled but no signing will happen.
How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>publisher/signingwidget.cpp <span style="color: grey">(e63dbbd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105074/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic