'Re: Review Request: Fix behavior of "runners" property'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix behavior of "runners" property
From:       "Commit Hook" <null () kde ! org>
Date:       2012-05-29 15:44:06
Message-ID: 20120529154406.5316.4321 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105024/#review14270
-----------------------------------------------------------

This review has been submitted with commit f4d08af8d2b41002ff2cd88ca9678a0131667260 \
by Aurélien Gâteau to branch master.

- Commit Hook

On May 24, 2012, 11:53 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105024/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 11:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This commit changes the behavior of the "runners" property when no manager has been \
>                 created yet:
> - Setting the property emits runnersChanged() (unless it is the same as the old \
>                 value)
> - Reading the property after setting it returns the new value
> 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/krunnermodel/runnermodel.cpp 2717ef8 
> 
> Diff: http://git.reviewboard.kde.org/r/105024/diff/
> 
> 
> Testing
> -------
> 
> Run attached test script. Without the patch, output is:
> """
> runners before: 
> runners after:
> """
> 
> With the patch one gets:
> """
> runners before: 
> onRunnersChanged(): runners=services,shell
> runners after: services,shell
> """
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105024/">http://git.reviewboard.kde.org/r/105024/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f4d08af8d2b41002ff2cd88ca9678a0131667260 by Aurélien Gâteau \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 24th, 2012, 11:53 a.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated May 24, 2012, 11:53 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This commit changes the behavior of the &quot;runners&quot; property \
                when no manager has been created yet:
- Setting the property emits runnersChanged() (unless it is the same as the old \
                value)
- Reading the property after setting it returns the new value</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run attached test script. Without the patch, output is: \
&quot;&quot;&quot; runners before: 
runners after:
&quot;&quot;&quot;

With the patch one gets:
&quot;&quot;&quot;
runners before: 
onRunnersChanged(): runners=services,shell
runners after: services,shell
&quot;&quot;&quot;</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/krunnermodel/runnermodel.cpp <span style="color: \
grey">(2717ef8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105024/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 