From kde-panel-devel Tue May 29 15:44:06 2012 From: "Commit Hook" Date: Tue, 29 May 2012 15:44:06 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix behavior of "runners" property Message-Id: <20120529154406.5316.4321 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133830643905456 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1526802862403341122==" --===============1526802862403341122== Content-Type: multipart/alternative; boundary="===============0327995720445095077==" --===============0327995720445095077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105024/#review14270 ----------------------------------------------------------- This review has been submitted with commit f4d08af8d2b41002ff2cd88ca9678a01= 31667260 by Aur=C3=A9lien G=C3=A2teau to branch master. - Commit Hook On May 24, 2012, 11:53 a.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105024/ > ----------------------------------------------------------- > = > (Updated May 24, 2012, 11:53 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > This commit changes the behavior of the "runners" property when no manage= r has been created yet: > - Setting the property emits runnersChanged() (unless it is the same as t= he old value) > - Reading the property after setting it returns the new value > = > = > Diffs > ----- > = > plasma/declarativeimports/krunnermodel/runnermodel.cpp 2717ef8 = > = > Diff: http://git.reviewboard.kde.org/r/105024/diff/ > = > = > Testing > ------- > = > Run attached test script. Without the patch, output is: > """ > runners before: = > runners after: > """ > = > With the patch one gets: > """ > runners before: = > onRunnersChanged(): runners=3Dservices,shell > runners after: services,shell > """ > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============0327995720445095077== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105024/ 

This revie=
w has been submitted with commit f4d08af8d2b41002ff2cd88ca9678a0131667260 b=
y Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit


On May 24th, 2012, 11:53 a.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma.
By Aur=C3=A9lien G=C3=A2teau.

Updated May 24, 2012, 11:53 a.m.

Descripti= on 

This commit changes the behavior of the "runners" =
property when no manager has been created yet:
- Setting the property emits runnersChanged() (unless it is the same as the=
 old value)
- Reading the property after setting it returns the new value

Testing <= /h1> 
Run attached test script. Without the patch, output is:
"""
runners before: =

runners after:
"""

With the patch one gets:
"""
runners before: =

onRunnersChanged(): runners=3Dservices,shell
runners after: services,shell
"""

Diffs=

  • plasma/declarativeimports/krunnermodel/runnermodel.cpp (2717ef8)

View Diff
--===============0327995720445095077==-- --===============1526802862403341122== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1526802862403341122==--