[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix behavior of "runners" property
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-05-27 18:26:27
Message-ID: 20120527182627.9571.18485 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105024/#review14209
-----------------------------------------------------------
good catch; two small fixes needed and then please commit :)
plasma/declarativeimports/krunnermodel/runnermodel.cpp
<http://git.reviewboard.kde.org/r/105024/#comment11229>
we do not use the "_ after name" paradigm; let's not start it here :)
plasma/declarativeimports/krunnermodel/runnermodel.cpp
<http://git.reviewboard.kde.org/r/105024/#comment11230>
this probably doesn't work as expected. m_maner->allowedRunners() returns the \
values from a QHash, which is not sorted. so both lists need to be sorted.
i would suggest something like this:
QStringList newRunnerList = allowedRunners;
qSort(allowedRunners);
QStringList currentRunnerList = runners();
qSort(currentRunners);
if (currentRunnerList == newRunnerList)
- Aaron J. Seigo
On May 24, 2012, 11:53 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105024/
> -----------------------------------------------------------
>
> (Updated May 24, 2012, 11:53 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This commit changes the behavior of the "runners" property when no manager has been \
> created yet:
> - Setting the property emits runnersChanged() (unless it is the same as the old \
> value)
> - Reading the property after setting it returns the new value
>
>
> Diffs
> -----
>
> plasma/declarativeimports/krunnermodel/runnermodel.cpp 2717ef8
>
> Diff: http://git.reviewboard.kde.org/r/105024/diff/
>
>
> Testing
> -------
>
> Run attached test script. Without the patch, output is:
> """
> runners before:
> runners after:
> """
>
> With the patch one gets:
> """
> runners before:
> onRunnersChanged(): runners=services,shell
> runners after: services,shell
> """
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105024/">http://git.reviewboard.kde.org/r/105024/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good catch; two small \
fixes needed and then please commit :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105024/diff/1/?file=65328#file65328line75" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/krunnermodel/runnermodel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
RunnerModel::count() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">75</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">RunnerModel</span><span class="o">::</span><span \
class="n">setRunners</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QStringList</span> <span class="o">&</span><span \
class="n">allowedRunners</span><span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">RunnerModel</span><span \
class="o">::</span><span class="n">setRunners</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QStringList</span> <span \
class="o">&</span><span class="n">allowedRunners<span \
class="hl">_</span></span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we do not \
use the "_ after name" paradigm; let's not start it here :)</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105024/diff/1/?file=65328#file65328line78" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/krunnermodel/runnermodel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
RunnerModel::count() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">78</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QStringList</span> <span class="n">allowedRunners</span> <span \
class="o">=</span> <span class="n">allowedRunners_</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">allowedRunners</span><span class="p">.</span><span \
class="n">sort</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">runners</span><span \
class="p">()</span> <span class="o">==</span> <span \
class="n">allowedRunners</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this \
probably doesn't work as expected. m_maner->allowedRunners() returns the \
values from a QHash, which is not sorted. so both lists need to be sorted.
i would suggest something like this:
QStringList newRunnerList = allowedRunners;
qSort(allowedRunners);
QStringList currentRunnerList = runners();
qSort(currentRunners);
if (currentRunnerList == newRunnerList)</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On May 24th, 2012, 11:53 a.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated May 24, 2012, 11:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This commit changes the behavior of the "runners" property \
when no manager has been created yet:
- Setting the property emits runnersChanged() (unless it is the same as the old \
value)
- Reading the property after setting it returns the new value</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run attached test script. Without the patch, output is: \
""" runners before:
runners after:
"""
With the patch one gets:
"""
runners before:
onRunnersChanged(): runners=services,shell
runners after: services,shell
"""</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/krunnermodel/runnermodel.cpp <span style="color: \
grey">(2717ef8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105024/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic