[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add Tilt-Wheel, "XButton1", and "XButton2" support for Kickoff GUI
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-28 4:18:51
Message-ID: 20120328041851.14768.27887 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104406/#review11935
-----------------------------------------------------------
This review has been submitted with commit 3d216ac247e92575830a7a99c2d0b849b069f103 \
by Rick Stockton to branch KDE/4.8.
- Commit Hook
On March 26, 2012, 5:10 p.m., Richard Stockton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104406/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 5:10 p.m.)
>
>
> Review request for Plasma, Kevin Ottens, Aaron J. Seigo, and Martin Gräßlin.
>
>
> Description
> -------
>
> Workaround removal of the "Back Button" (in 4.7): In the
> "Applications" GUI, users with tilt-wheel mice can use "Tilt-Left"
> as a "Back Button" equivalent. And, if the focused item is a
> Parent for other items, "Tilt-Right" will move to the right,
> expanding the Children.
>
> In addition: For "gamer" mice with thumb buttons, "XButton1"
> (AKA the "back" button) is made to work just like the "Tilt-Left"
> Wheel Event; and "XButton2" is made to work just like "Tilt-Right".
>
>
> This addresses bug 289519.
> http://bugs.kde.org/show_bug.cgi?id=289519
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c
> plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd
>
> Diff: http://git.reviewboard.kde.org/r/104406/diff/
>
>
> Testing
> -------
>
> Compiled, Built and Run. (Although another function, which I did not touch, \
> provokes two "unused variable" warnings). My desktop is otherwise 4.8.1, and I am \
> using this code "in production". New buttons work; Tilt wheel works; I have seen \
> no regressions.
>
> Thanks,
>
> Richard Stockton
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104406/">http://git.reviewboard.kde.org/r/104406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3d216ac247e92575830a7a99c2d0b849b069f103 by Rick Stockton to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 26th, 2012, 5:10 p.m., Richard Stockton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Kevin Ottens, Aaron J. Seigo, and Martin \
Gräßlin.</div> <div>By Richard Stockton.</div>
<p style="color: grey;"><i>Updated March 26, 2012, 5:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Workaround removal of the "Back Button" (in 4.7): In the \
"Applications" GUI, users with tilt-wheel mice can use \
"Tilt-Left" as a "Back Button" equivalent. And, if the focused \
item is a Parent for other items, "Tilt-Right" will move to the right,
expanding the Children.
In addition: For "gamer" mice with thumb buttons, "XButton1"
(AKA the "back" button) is made to work just like the "Tilt-Left"
Wheel Event; and "XButton2" is made to work just like \
"Tilt-Right".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, Built and Run. (Although another function, which I did not \
touch, provokes two "unused variable" warnings). My desktop is otherwise \
4.8.1, and I am using this code "in production". New buttons work; Tilt \
wheel works; I have seen no regressions.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289519">289519</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/flipscrollview.h <span style="color: \
grey">(bf12b9c)</span></li>
<li>plasma/desktop/applets/kickoff/ui/flipscrollview.cpp <span style="color: \
grey">(98bc0bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic