'Review Request: Misc minor fixes in KRunner.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Misc minor fixes in KRunner.
From:       "David Edmundson" <kde () davidedmundson ! co ! uk>
Date:       2012-03-28 1:56:55
Message-ID: 20120328015655.640.14253 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104431/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

* Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is imp=
lied from the context and to bring consistency.
* Add correct icon for activities runner
* Use correct case in description of "places" runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pi=
xels from the top margin to only use 1.
* Reword "Available Features" to "Available Plugins" for consistency
* Make the krunner config dialog appear to load slightly faster by loading =
the list of plugins after we've shown the dialog.
* Remove undefined (and unused) private method.

Diffs
-----

  krunner/configdialog.h a9c353a =

  krunner/configdialog.cpp 80485ca =

  krunner/krunnerdialog.cpp 007887f =

  plasma/generic/dataengines/activities/activityengine.cpp cbbc559 =

  plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 85=
3c680 =

  plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop =
0319463 =

  plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 =

  plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop f2=
34b4f =

Diff: http://git.reviewboard.kde.org/r/104431/diff/

Testing
-------

Thanks,

David Edmundson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104431/">http://git.reviewboard.kde.org/r/104431/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Remove &quot;runner&quot; from &quot;Nepomuk Desktop Search \
                Runner&quot; as the runner is implied from the context and to bring \
                consistency.
* Add correct icon for activities runner
* Use correct case in description of &quot;places&quot; runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pixels from \
                the top margin to only use 1.
* Reword &quot;Available Features&quot; to &quot;Available Plugins&quot; for \
                consistency
* Make the krunner config dialog appear to load slightly faster by loading the list \
                of plugins after we&#39;ve shown the dialog.
* Remove undefined (and unused) private method.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krunner/configdialog.h <span style="color: grey">(a9c353a)</span></li>

 <li>krunner/configdialog.cpp <span style="color: grey">(80485ca)</span></li>

 <li>krunner/krunnerdialog.cpp <span style="color: grey">(007887f)</span></li>

 <li>plasma/generic/dataengines/activities/activityengine.cpp <span style="color: \
grey">(cbbc559)</span></li>

 <li>plasma/generic/runners/activities/plasma-runner-activityrunner.desktop <span \
style="color: grey">(853c680)</span></li>

 <li>plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop <span \
style="color: grey">(0319463)</span></li>

 <li>plasma/generic/runners/places/plasma-runner-places.desktop <span style="color: \
grey">(b82fa14)</span></li>

 <li>plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop <span \
style="color: grey">(f234b4f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104431/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 