From kde-panel-devel Wed Mar 28 04:18:51 2012 From: "Commit Hook" Date: Wed, 28 Mar 2012 04:18:51 +0000 To: kde-panel-devel Subject: Re: Review Request: Add Tilt-Wheel, "XButton1", and "XButton2" support for Kickoff GUI Message-Id: <20120328041851.14768.27887 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133290844727733 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7534523091747731790==" --===============7534523091747731790== Content-Type: multipart/alternative; boundary="===============3596364257319036820==" --===============3596364257319036820== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104406/#review11935 ----------------------------------------------------------- This review has been submitted with commit 3d216ac247e92575830a7a99c2d0b849= b069f103 by Rick Stockton to branch KDE/4.8. - Commit Hook On March 26, 2012, 5:10 p.m., Richard Stockton wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104406/ > ----------------------------------------------------------- > = > (Updated March 26, 2012, 5:10 p.m.) > = > = > Review request for Plasma, Kevin Ottens, Aaron J. Seigo, and Martin Gr=C3= =A4=C3=9Flin. > = > = > Description > ------- > = > Workaround removal of the "Back Button" (in 4.7): In the > "Applications" GUI, users with tilt-wheel mice can use "Tilt-Left" > as a "Back Button" equivalent. And, if the focused item is a > Parent for other items, "Tilt-Right" will move to the right, > expanding the Children. > = > In addition: For "gamer" mice with thumb buttons, "XButton1" > (AKA the "back" button) is made to work just like the "Tilt-Left" > Wheel Event; and "XButton2" is made to work just like "Tilt-Right". > = > = > This addresses bug 289519. > http://bugs.kde.org/show_bug.cgi?id=3D289519 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/ui/flipscrollview.h bf12b9c = > plasma/desktop/applets/kickoff/ui/flipscrollview.cpp 98bc0bd = > = > Diff: http://git.reviewboard.kde.org/r/104406/diff/ > = > = > Testing > ------- > = > Compiled, Built and Run. (Although another function, which I did not touc= h, provokes two "unused variable" warnings). > My desktop is otherwise 4.8.1, and I am using this code "in production". = > New buttons work; Tilt wheel works; I have seen no regressions. > = > = > Thanks, > = > Richard Stockton > = > --===============3596364257319036820== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104406/ 

This revie=
w has been submitted with commit 3d216ac247e92575830a7a99c2d0b849b069f103 b=
y Rick Stockton to branch KDE/4.8.

- Commit


On March 26th, 2012, 5:10 p.m., Richard Stockton wrote:

Review request for Plasma, Kevin Ottens, Aaron J. Seigo, and Martin Gr= =C3=A4=C3=9Flin.
By Richard Stockton.

Updated March 26, 2012, 5:10 p.m.

Descripti= on 

Workaround removal of the "Back Button" (in 4.7): =
In the
"Applications" GUI, users with tilt-wheel mice can use "Tilt=
-Left"
as a "Back Button" equivalent. And, if the focused item is a
Parent for other items, "Tilt-Right" will move to the right,
expanding the Children.

In addition: For "gamer" mice with thumb buttons, "XButton1&=
quot;
(AKA the "back" button) is made to work just like the "Tilt-=
Left"
Wheel Event; and "XButton2" is made to work just like "Tilt-=
Right".

Testing <= /h1> 
Compiled, Built and Run. (Although another function, which I=
 did not touch, provokes two "unused variable" warnings).
My desktop is otherwise 4.8.1, and I am using this code "in production=
". =

New buttons work; Tilt wheel works; I have seen no regressions.
Bugs: 289519

Diffs=

  • plasma/desktop/applets/kickoff/ui/flipscrollview.h (bf12b9c)
  • plasma/desktop/applets/kickoff/ui/flipscrollview.cpp (98bc0bd)

View Diff
--===============3596364257319036820==-- --===============7534523091747731790== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7534523091747731790==--