--===============5948605371990868024== Content-Type: multipart/alternative; boundary="===============4482658392429420815==" --===============4482658392429420815== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104431/ ----------------------------------------------------------- Review request for Plasma. Description ------- * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is imp= lied from the context and to bring consistency. * Add correct icon for activities runner * Use correct case in description of "places" runner. * Use correct case in Webshorts runner description * Match top and bottom margin sizes. This updates a bodge that removed 2 pi= xels from the top margin to only use 1. * Reword "Available Features" to "Available Plugins" for consistency * Make the krunner config dialog appear to load slightly faster by loading = the list of plugins after we've shown the dialog. * Remove undefined (and unused) private method. Diffs ----- krunner/configdialog.h a9c353a = krunner/configdialog.cpp 80485ca = krunner/krunnerdialog.cpp 007887f = plasma/generic/dataengines/activities/activityengine.cpp cbbc559 = plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 85= 3c680 = plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop = 0319463 = plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 = plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop f2= 34b4f = Diff: http://git.reviewboard.kde.org/r/104431/diff/ Testing ------- Thanks, David Edmundson --===============4482658392429420815== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104431/

Review request for Plasma.
By David Edmundson.

Descripti= on 

* Remove "runner" from "Nepomuk Desktop Searc=
h Runner" as the runner is implied from the context and to bring consi=
stency.
* Add correct icon for activities runner
* Use correct case in description of "places" runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pi=
xels from the top margin to only use 1.
* Reword "Available Features" to "Available Plugins" fo=
r consistency
* Make the krunner config dialog appear to load slightly faster by loading =
the list of plugins after we've shown the dialog.
* Remove undefined (and unused) private method.

Diffs=

  • krunner/configdialog.h (a9c353a)
  • krunner/configdialog.cpp (80485ca)<= /li>
  • krunner/krunnerdialog.cpp (007887f)=
  • plasma/generic/dataengines/activities/activityengine.cpp (cbbc559)
  • plasma/generic/runners/activities/plasma-runner-activityrunner.desktop= (853c680)
  • plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.deskt= op (0319463)
  • plasma/generic/runners/places/plasma-runner-places.desktop (b82fa14)
  • plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop= (f234b4f)

View Diff
--===============4482658392429420815==-- --===============5948605371990868024== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5948605371990868024==--