'Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()
From:       "Commit Hook" <null () kde ! org>
Date:       2012-01-20 11:00:41
Message-ID: 20120120110041.25164.88836 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103735/#review9963
-----------------------------------------------------------

This review has been submitted with commit a82bb8cb44f1c3e82f38d51f2867452d9cf54d9b \
by Ignat Semenov to branch master.

- Commit Hook

On Jan. 20, 2012, 9:36 a.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103735/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 9:36 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> Currently, the FolderView::IconView::itemSize() method accounts for the margins \
> only if size.width()>ts.width(), that is, the icon+margins is wider than the text. \
> However, when ts.width()>size.width(), the margins are not accounted for, and \
> size.width()=ts.width(). This can be observed easily. The patch adds those margins \
> to the second operand of the comparison macro. 
> 
> Diffs
> -----
> 
> plasma/applets/folderview/iconview.cpp 09b9c80 
> 
> Diff: http://git.reviewboard.kde.org/r/103735/diff/diff
> 
> 
> Testing
> -------
> 
> Tested by manually changing the paintItem() code to use the itemSize() rect and \
> observing the improved behaviour. 
> 
> Thanks,
> 
> Ignat Semenov
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103735/">http://git.reviewboard.kde.org/r/103735/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a82bb8cb44f1c3e82f38d51f2867452d9cf54d9b by Ignat Semenov to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 20th, 2012, 9:36 a.m., Ignat Semenov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2012, 9:36 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the FolderView::IconView::itemSize() method accounts for the \
margins only if size.width()&gt;ts.width(), that is, the icon+margins is wider than \
the text. However, when ts.width()&gt;size.width(), the margins are not accounted \
for, and size.width()=ts.width(). This can be observed easily. The patch adds those \
margins to the second operand of the comparison macro.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by manually changing the paintItem() code to use the itemSize() \
rect and observing the improved behaviour.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(09b9c80)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103735/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 