This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/ 

This review has been submitted with commit a82bb8cb44f1c3e82f38d51f2867452d9cf54d9b by Ignat Semenov to branch master.

- Commit


On January 20th, 2012, 9:36 a.m., Ignat Semenov wrote:

Review request for Plasma, Aaron J. Seigo and Marco Martin.
By Ignat Semenov.

Updated Jan. 20, 2012, 9:36 a.m.

Description 

Currently, the FolderView::IconView::itemSize() method accounts for the margins only if size.width()>ts.width(), that is, the icon+margins is wider than the text. However, when ts.width()>size.width(), the margins are not accounted for, and size.width()=ts.width(). This can be observed easily. The patch adds those margins to the second operand of the comparison macro.

Testing 

Tested by manually changing the paintItem() code to use the itemSize() rect and observing the improved behaviour.

Diffs

  • plasma/applets/folderview/iconview.cpp (09b9c80)

View Diff