From kde-panel-devel Fri Jan 20 11:00:41 2012 From: "Commit Hook" Date: Fri, 20 Jan 2012 11:00:41 +0000 To: kde-panel-devel Subject: Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize() Message-Id: <20120120110041.25164.88836 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132705742907851 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0543281961783906323==" --===============0543281961783906323== Content-Type: multipart/alternative; boundary="===============3630244888972696348==" --===============3630244888972696348== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/#review9963 ----------------------------------------------------------- This review has been submitted with commit a82bb8cb44f1c3e82f38d51f2867452d= 9cf54d9b by Ignat Semenov to branch master. - Commit Hook On Jan. 20, 2012, 9:36 a.m., Ignat Semenov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103735/ > ----------------------------------------------------------- > = > (Updated Jan. 20, 2012, 9:36 a.m.) > = > = > Review request for Plasma, Aaron J. Seigo and Marco Martin. > = > = > Description > ------- > = > Currently, the FolderView::IconView::itemSize() method accounts for the m= argins only if size.width()>ts.width(), that is, the icon+margins is wider = than the text. However, when ts.width()>size.width(), the margins are not a= ccounted for, and size.width()=3Dts.width(). This can be observed easily. T= he patch adds those margins to the second operand of the comparison macro. > = > = > Diffs > ----- > = > plasma/applets/folderview/iconview.cpp 09b9c80 = > = > Diff: http://git.reviewboard.kde.org/r/103735/diff/diff > = > = > Testing > ------- > = > Tested by manually changing the paintItem() code to use the itemSize() re= ct and observing the improved behaviour. > = > = > Thanks, > = > Ignat Semenov > = > --===============3630244888972696348== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103735/ 

This revie=
w has been submitted with commit a82bb8cb44f1c3e82f38d51f2867452d9cf54d9b b=
y Ignat Semenov to branch master.

- Commit


On January 20th, 2012, 9:36 a.m., Ignat Semenov wrote:

Review request for Plasma, Aaron J. Seigo and Marco Martin.
By Ignat Semenov.

Updated Jan. 20, 2012, 9:36 a.m.

Descripti= on 

Currently, the FolderView::IconView::itemSize() method accou=
nts for the margins only if size.width()>ts.width(), that is, the icon+m=
argins is wider than the text. However, when ts.width()>size.width(), th=
e margins are not accounted for, and size.width()=3Dts.width(). This can be=
 observed easily. The patch adds those margins to the second operand of the=
 comparison macro.

Testing <= /h1> 
Tested by manually changing the paintItem() code to use the =
itemSize() rect and observing the improved behaviour.

Diffs=

  • plasma/applets/folderview/iconview.cpp (09= b9c80)

View Diff
--===============3630244888972696348==-- --===============0543281961783906323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0543281961783906323==--