[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix "Add to desktop" from Kickoff when you have several
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-01-11 13:29:45
Message-ID: 20120111132945.13514.70885 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103645/#review9744
-----------------------------------------------------------
Ship it!
tiny ws issue, but otherwise ok.
and why containment starts from 0 -> because that's where counting starts. \
that virtual desktops in KWindowSystem start at '1' is pretty silly, \
really. otherwise we end up with everything else being zeroth counted as \
per usual, except desktops which are counted from 1. i chose not to extend \
that oddity into plasma code.
plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
<http://git.reviewboard.kde.org/r/103645/#comment8045>
spaces around the '-' please :)
- Aaron J. Seigo
On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103645/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2012, 9:11 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> From Kickoff using "Add to desktop" when you have several virtual \
> desktops and you enable "Different widgets for each desktop" in the pager \
> settings. KWindowSystem starts counting from 1 and Plasma from 0
> Without this fix "Add to desktop" adds to the next desktop or does not \
> add if you're on the last desktop.
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=290368.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903
>
> Diff: http://git.reviewboard.kde.org/r/103645/diff/diff
>
>
> Testing
> -------
>
> Local tests as thorough as I could do.
>
>
> Thanks,
>
> Anne-Marie Mahfouf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103645/">http://git.reviewboard.kde.org/r/103645/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tiny ws issue, but otherwise ok.
and why containment starts from 0 -> because that's where counting \
starts. that virtual desktops in KWindowSystem start at '1' is \
pretty silly, really. otherwise we end up with everything else being zeroth \
counted as per usual, except desktops which are counted from 1. i chose not \
to extend that oddity into plasma code.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid \
#C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid \
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103645/diff/1/?file=45988#file45988line312" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: \
center;"> <tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void ContextMenuFactory::showContextMenu(QAbstractItemView \
*view,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">312</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">int</span> <span class="n">vdesk</span> <span \
class="o">=</span> <span class="n">KWindowSystem</span><span \
class="o">::</span><span class="n">currentDesktop</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">312</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">int</span> <span class="n">vdesk</span> <span \
class="o">=</span> <span class="n">KWindowSystem</span><span \
class="o">::</span><span class="n">currentDesktop</span><span \
class="p">()</span><span class="o"><span class="hl">-</span></span><span \
class="mi"><span class="hl">1</span></span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">spaces around the '-' please :)</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On January 6th, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2012, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">From Kickoff using "Add to desktop" when you have \
several virtual desktops and you enable "Different widgets for each \
desktop" in the pager settings. KWindowSystem starts counting from 1 \
and Plasma from 0
Without this fix "Add to desktop" adds to the next desktop or \
does not add if you're on the last desktop. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Local tests as thorough as I could do.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368">https://bugs.kde.org/show_bug.cgi?id=290368</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <span \
style="color: grey">(cf12903)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103645/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic