--===============4333179168900324387== Content-Type: multipart/alternative; boundary="===============6639765378529682567==" --===============6639765378529682567== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9744 ----------------------------------------------------------- Ship it! tiny ws issue, but otherwise ok. and why containment starts from 0 -> because that's where counting starts. = that virtual desktops in KWindowSystem start at '1' is pretty silly, really= . otherwise we end up with everything else being zeroth counted as per usua= l, except desktops which are counted from 1. i chose not to extend that odd= ity into plasma code. plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp spaces around the '-' please :) - Aaron J. Seigo On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103645/ > ----------------------------------------------------------- > = > (Updated Jan. 6, 2012, 9:11 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > From Kickoff using "Add to desktop" when you have several virtual desktop= s and you enable "Different widgets for each desktop" in the pager settings= . KWindowSystem starts counting from 1 and Plasma from 0 > = > Without this fix "Add to desktop" adds to the next desktop or does not ad= d if you're on the last desktop. = > = > = > This addresses bug https://bugs.kde.org/show_bug.cgi?id=3D290368. > http://bugs.kde.org/show_bug.cgi?id=3Dhttps://bugs.kde.org/show_bug.c= gi?id=3D290368 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903 = > = > Diff: http://git.reviewboard.kde.org/r/103645/diff/diff > = > = > Testing > ------- > = > Local tests as thorough as I could do. > = > = > Thanks, > = > Anne-Marie Mahfouf > = > --===============6639765378529682567== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103645/

Ship it!

tiny ws is=
sue, but otherwise ok.

and why containment starts from 0 -> because that's where counting s=
tarts. that virtual desktops in KWindowSystem start at '1' is prett=
y silly, really. otherwise we end up with everything else being zeroth coun=
ted as per usual, except desktops which are counted from 1. i chose not to =
extend that oddity into plasma code.

= =
plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp (Diff revision 1) 
void ContextMenuFactory::showContextMenu(QAbstractItemView *view,
312 
                    int vdesk =3D KWindowSystem::cur=
rentDesktop();
 312 
                    int vdesk =3D KWindowSystem::cur=
rentDesktop()-1;
 
spaces around the '-' please :)

- Aaron J.


On January 6th, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:

Review request for Plasma and Aaron J. Seigo.
By Anne-Marie Mahfouf.

Updated Jan. 6, 2012, 9:11 p.m.

Descripti= on 

From Kickoff using "Add to desktop" when you have =
several virtual desktops and you enable "Different widgets for each de=
sktop" in the pager settings. KWindowSystem starts counting from 1 and=
 Plasma from 0

Without this fix "Add to desktop" adds to the next desktop or doe=
s not add if you're on the last desktop.

Testing <= /h1> 
Local tests as thorough as I could do.

Diffs=

  • plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp (cf12903)

View Diff
--===============6639765378529682567==-- --===============4333179168900324387== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4333179168900324387==--