This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/

Ship it!

tiny ws issue, but otherwise ok.

and why containment starts from 0 -> because that's where counting starts. that virtual desktops in KWindowSystem start at '1' is pretty silly, really. otherwise we end up with everything else being zeroth counted as per usual, except desktops which are counted from 1. i chose not to extend that oddity into plasma code.

plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp (Diff revision 1)
void ContextMenuFactory::showContextMenu(QAbstractItemView *view,
312
                    int vdesk = KWindowSystem::currentDesktop();
312
                    int vdesk = KWindowSystem::currentDesktop()-1;
spaces around the '-' please :)

- Aaron J.


On January 6th, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:

Review request for Plasma and Aaron J. Seigo.
By Anne-Marie Mahfouf.

Updated Jan. 6, 2012, 9:11 p.m.

Description

From Kickoff using "Add to desktop" when you have several virtual desktops and you enable "Different widgets for each desktop" in the pager settings. KWindowSystem starts counting from 1 and Plasma from 0

Without this fix "Add to desktop" adds to the next desktop or does not add if you're on the last desktop. 

Testing

Local tests as thorough as I could do.

Diffs

  • plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp (cf12903)

View Diff