'Review Request: Apply the new settings in Folderview on clicking the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Apply the new settings in Folderview on clicking the
From:       "Ignat Semenov" <13thguards () gmail ! com>
Date:       2011-12-26 18:26:29
Message-ID: 20111226182629.21166.30153 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103545/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.

Description
-------

Currently, after Aaron's patch https://projects.kde.org/projects/kde/kde-ba=
seapps/repository/revisions/10a7c8aaa06d73a1415d128f25000f7335a59d25, certa=
in FolderView settings are not changed on the fly (but instead change only =
after a plasma-desktop restart) after I hit the "Apply" button. E.g. the "C=
lick to enter folder", or "Show Desktop/Home/cutom location", and others. I=
 think this is because the settings are written to disk, but are not applie=
d in configAccepted(). This patch adds a configChanged() call right before =
the configAccepted() function end.

Diffs
-----

  plasma/applets/folderview/folderview.cpp d620a7d =

Diff: http://git.reviewboard.kde.org/r/103545/diff/diff

Testing
-------

Works fine after the patch. Settings are indeed changed after hitting the "=
Apply" button.

I'm not sure, however, whether the configChanged() should go before the tim=
er or after it. My guess is that the timer call is there in order to allow =
the newly written settings to sync to the hard disk, so I put the call at t=
he very end of the accepted() method.

Thanks,

Ignat Semenov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103545/">http://git.reviewboard.kde.org/r/103545/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Ignat Semenov.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, after Aaron&#39;s patch \
https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/10a7c8aaa06d73a1415d128f25000f7335a59d25, \
certain FolderView settings are not changed on the fly (but instead change only after \
a plasma-desktop restart) after I hit the &quot;Apply&quot; button. E.g. the \
&quot;Click to enter folder&quot;, or &quot;Show Desktop/Home/cutom location&quot;, \
and others. I think this is because the settings are written to disk, but are not \
applied in configAccepted(). This patch adds a configChanged() call right before the \
configAccepted() function end.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine after the patch. Settings are indeed changed after hitting \
the &quot;Apply&quot; button.

I&#39;m not sure, however, whether the configChanged() should go before the timer or \
after it. My guess is that the timer call is there in order to allow the newly \
written settings to sync to the hard disk, so I put the call at the very end of the \
accepted() method.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(d620a7d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103545/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 