[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: =?utf-8?q?Re=3A_Review_Request=3A_F=C3=AFx_two_little_bugs=3A_one_with_de?=
From: "Ignat Semenov" <13thguards () gmail ! com>
Date: 2011-12-26 18:15:50
Message-ID: 20111226181550.17590.47359 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103529/#review9282
-----------------------------------------------------------
Ship it!
Given that two developers have both given positive feedback on the relevant=
parts of the patch, although independently, I can use the right to give th=
e review a ship it!
Nikita Churaev, do you have a developer account to commit the changes? If n=
ot, you can request a developer account at your identity.kde.org personal p=
age using a similarly named button.
- Ignat Semenov
On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103529/
> -----------------------------------------------------------
> =
> (Updated Dec. 24, 2011, 5:35 p.m.)
> =
> =
> Review request for kdelibs and Plasma.
> =
> =
> Description
> -------
> =
> Contrast bug: KGlobalSettings::contrast() returns different default value=
than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color=
control module uses contrast(), so when the user first uses color settings=
, contrast appears to change.
> =
> Plasma popup bug: Right-aligned popups are one pixel away from right edge=
of the screen and top-aligned popups (when panel is on top) are one pixel =
inside panel. This is because the bug in QRect, where right() and bottom() =
value return value that is less than the true value by one. This is a featu=
re-bug that Qt developers aren't going to fix because of compatiability rea=
sons. My patch just applies + 1 compensation to all expressions that use QR=
ect::right() and QRect::bottom().
> =
> =
> Diffs
> -----
> =
> kdeui/kernel/kglobalsettings.cpp 819b314 =
> plasma/corona.cpp 366a9df =
> =
> Diff: http://git.reviewboard.kde.org/r/103529/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Nikita Churaev
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103529/">http://git.reviewboard.kde.org/r/103529/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given that two \
developers have both given positive feedback on the relevant parts of the patch, \
although independently, I can use the right to give the review a ship it!
Nikita Churaev, do you have a developer account to commit the changes? If not, you \
can request a developer account at your identity.kde.org personal page using a \
similarly named button.</pre> <br />
<p>- Ignat</p>
<br />
<p>On December 24th, 2011, 5:35 p.m., Nikita Churaev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Nikita Churaev.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2011, 5:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Contrast bug: KGlobalSettings::contrast() returns different default \
value than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color \
control module uses contrast(), so when the user first uses color settings, contrast \
appears to change.
Plasma popup bug: Right-aligned popups are one pixel away from right edge of the \
screen and top-aligned popups (when panel is on top) are one pixel inside panel. This \
is because the bug in QRect, where right() and bottom() value return value that is \
less than the true value by one. This is a feature-bug that Qt developers aren't \
going to fix because of compatiability reasons. My patch just applies + 1 \
compensation to all expressions that use QRect::right() and QRect::bottom().</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(819b314)</span></li>
<li>plasma/corona.cpp <span style="color: grey">(366a9df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103529/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic