From kde-panel-devel Mon Dec 26 18:26:29 2011 From: "Ignat Semenov" <13thguards () gmail ! com> Date: Mon, 26 Dec 2011 18:26:29 +0000 To: kde-panel-devel Subject: Review Request: Apply the new settings in Folderview on clicking the Message-Id: <20111226182629.21166.30153 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132492923804994 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1817347103709727454==" --===============1817347103709727454== Content-Type: multipart/alternative; boundary="===============7230680876533190359==" --===============7230680876533190359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103545/ ----------------------------------------------------------- Review request for Plasma and Aaron J. Seigo. Description ------- Currently, after Aaron's patch https://projects.kde.org/projects/kde/kde-ba= seapps/repository/revisions/10a7c8aaa06d73a1415d128f25000f7335a59d25, certa= in FolderView settings are not changed on the fly (but instead change only = after a plasma-desktop restart) after I hit the "Apply" button. E.g. the "C= lick to enter folder", or "Show Desktop/Home/cutom location", and others. I= think this is because the settings are written to disk, but are not applie= d in configAccepted(). This patch adds a configChanged() call right before = the configAccepted() function end. Diffs ----- plasma/applets/folderview/folderview.cpp d620a7d = Diff: http://git.reviewboard.kde.org/r/103545/diff/diff Testing ------- Works fine after the patch. Settings are indeed changed after hitting the "= Apply" button. I'm not sure, however, whether the configChanged() should go before the tim= er or after it. My guess is that the timer call is there in order to allow = the newly written settings to sync to the hard disk, so I put the call at t= he very end of the accepted() method. Thanks, Ignat Semenov --===============7230680876533190359== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103545/

Review request for Plasma and Aaron J. Seigo.
By Ignat Semenov.

Descripti= on 

Currently, after Aaron's patch https://projects.kde.org/=
projects/kde/kde-baseapps/repository/revisions/10a7c8aaa06d73a1415d128f2500=
0f7335a59d25, certain FolderView settings are not changed on the fly (but i=
nstead change only after a plasma-desktop restart) after I hit the "Ap=
ply" button. E.g. the "Click to enter folder", or "Show=
 Desktop/Home/cutom location", and others. I think this is because the=
 settings are written to disk, but are not applied in configAccepted(). Thi=
s patch adds a configChanged() call right before the configAccepted() funct=
ion end.

Testing <= /h1> 
Works fine after the patch. Settings are indeed changed afte=
r hitting the "Apply" button.

I'm not sure, however, whether the configChanged() should go before the=
 timer or after it. My guess is that the timer call is there in order to al=
low the newly written settings to sync to the hard disk, so I put the call =
at the very end of the accepted() method.

Diffs=

  • plasma/applets/folderview/folderview.cpp (= d620a7d)

View Diff
--===============7230680876533190359==-- --===============1817347103709727454== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1817347103709727454==--