'Re: Review Request: Further fix for Bug 285731'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Further fix for Bug 285731
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2011-11-27 16:18:58
Message-ID: 20111127161858.23966.18457 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103260/#review8537
-----------------------------------------------------------

Sorry didn't see the review request and did almost the same one ;)

only difference is that i did put the check on the outer if, makes it behave slightly \
different but i don't hink it matters since when there is no scene is broken anyways \
(this as far i seen it does indeed happen during destruction)

- Marco Martin

On Nov. 26, 2011, 11:12 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103260/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 11:12 p.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Description
> -------
> 
> Though marked as Fixed, 285731 still exists on kde-runtime master.
> There is another scene variable need to be tested.
> 
> 
> This addresses bug 285731.
> http://bugs.kde.org/show_bug.cgi?id=285731
> 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/core/tooltip.cpp 4eaa5b8 
> 
> Diff: http://git.reviewboard.kde.org/r/103260/diff/diff
> 
> 
> Testing
> -------
> 
> No more crash
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103260/">http://git.reviewboard.kde.org/r/103260/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry didn&#39;t see the \
review request and did almost the same one ;)

only difference is that i did put the check on the outer if, makes it behave slightly \
different but i don&#39;t hink it matters since when there is no scene is broken \
anyways (this as far i seen it does indeed happen during destruction)</pre>  <br />

<p>- Marco</p>

<br />
<p>On November 26th, 2011, 11:12 p.m., Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime and Plasma.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2011, 11:12 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Though marked as Fixed, 285731 still exists on kde-runtime master. There \
is another scene variable need to be tested.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No more crash</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=285731">285731</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(4eaa5b8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103260/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 