--===============2899661129661307854== Content-Type: multipart/alternative; boundary="===============8059975877313305299==" --===============8059975877313305299== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103260/#review8537 ----------------------------------------------------------- Sorry didn't see the review request and did almost the same one ;) only difference is that i did put the check on the outer if, makes it behav= e slightly different but i don't hink it matters since when there is no sce= ne is broken anyways (this as far i seen it does indeed happen during destr= uction) - Marco Martin On Nov. 26, 2011, 11:12 p.m., Xuetian Weng wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103260/ > ----------------------------------------------------------- > = > (Updated Nov. 26, 2011, 11:12 p.m.) > = > = > Review request for KDE Runtime and Plasma. > = > = > Description > ------- > = > Though marked as Fixed, 285731 still exists on kde-runtime master. > There is another scene variable need to be tested. > = > = > This addresses bug 285731. > http://bugs.kde.org/show_bug.cgi?id=3D285731 > = > = > Diffs > ----- > = > plasma/declarativeimports/core/tooltip.cpp 4eaa5b8 = > = > Diff: http://git.reviewboard.kde.org/r/103260/diff/diff > = > = > Testing > ------- > = > No more crash > = > = > Thanks, > = > Xuetian Weng > = > --===============8059975877313305299== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103260/ 

Sorry didn=
't see the review request and did almost the same one ;)

only difference is that i did put the check on the outer if, makes it behav=
e slightly different but i don't hink it matters since when there is no=
 scene is broken anyways (this as far i seen it does indeed happen during d=
estruction)

- Marco


On November 26th, 2011, 11:12 p.m., Xuetian Weng wrote:

Review request for KDE Runtime and Plasma.
By Xuetian Weng.

Updated Nov. 26, 2011, 11:12 p.m.

Descripti= on 

Though marked as Fixed, 285731 still exists on kde-runtime m=
aster.
There is another scene variable need to be tested.

Testing <= /h1> 
No more crash
Bugs: 285731

Diffs=

  • plasma/declarativeimports/core/tooltip.cpp (4eaa5b8)

View Diff
--===============8059975877313305299==-- --===============2899661129661307854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2899661129661307854==--