'Re: Review Request: Plasmate can create a CMakeLists.txt at'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate can create a CMakeLists.txt at
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-11-24 10:06:23
Message-ID: 20111124100623.23360.48608 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102989/#review8440
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On Nov. 23, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102989/
> -----------------------------------------------------------
> =

> (Updated Nov. 23, 2011, 3 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> With this patch plasmate can now create a CMakeLists.txt.I haven't discus=
sed the patch with someone but i believe that plasmate needs this feature.
> =

> If so,at the publisher there is an install button should i convert it int=
o a combobox in order to add the option to install the project using
> cmake and not only using plasmapkg.Of course this will be an another patc=
h.
> =

> thanks in advance
> =

> =

> Diffs
> -----
> =

>   publisher/publisher.h 39b1f22 =

>   publisher/publisher.cpp fec24c8 =

>   templates/CMakeLists.txt b5f8d2b =

> =

> Diff: http://git.reviewboard.kde.org/r/102989/diff/diff
> =

> =

> Testing
> -------
> =

> the source code is fine,i am not sure about the quality of the CMakeLists=
.txt file
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliwkas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102989/">http://git.reviewboard.kde.org/r/102989/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On November 23rd, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2011, 3 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch plasmate can now create a CMakeLists.txt.I haven&#39;t \
discussed the patch with someone but i believe that plasmate needs this feature.

If so,at the publisher there is an install button should i convert it into a combobox \
in order to add the option to install the project using cmake and not only using \
plasmapkg.Of course this will be an another patch.

thanks in advance</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the source code is fine,i am not sure about the quality of the \
CMakeLists.txt file</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>publisher/publisher.h <span style="color: grey">(39b1f22)</span></li>

 <li>publisher/publisher.cpp <span style="color: grey">(fec24c8)</span></li>

 <li>templates/CMakeLists.txt <span style="color: grey">(b5f8d2b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102989/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 