From kde-panel-devel Thu Nov 24 10:06:23 2011 From: "Aaron J. Seigo" Date: Thu, 24 Nov 2011 10:06:23 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate can create a CMakeLists.txt at Message-Id: <20111124100623.23360.48608 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132212931311817 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5384450377964889800==" --===============5384450377964889800== Content-Type: multipart/alternative; boundary="===============8624257035897373716==" --===============8624257035897373716== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102989/#review8440 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On Nov. 23, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102989/ > ----------------------------------------------------------- > = > (Updated Nov. 23, 2011, 3 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > With this patch plasmate can now create a CMakeLists.txt.I haven't discus= sed the patch with someone but i believe that plasmate needs this feature. > = > If so,at the publisher there is an install button should i convert it int= o a combobox in order to add the option to install the project using > cmake and not only using plasmapkg.Of course this will be an another patc= h. > = > thanks in advance > = > = > Diffs > ----- > = > publisher/publisher.h 39b1f22 = > publisher/publisher.cpp fec24c8 = > templates/CMakeLists.txt b5f8d2b = > = > Diff: http://git.reviewboard.kde.org/r/102989/diff/diff > = > = > Testing > ------- > = > the source code is fine,i am not sure about the quality of the CMakeLists= .txt file > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============8624257035897373716== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102989/

Ship it!

Ship It!
 









- Aaron J.






On November 23rd, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:









 

  


Review request for Plasma.


By Giorgos Tsiapaliwkas.




Updated Nov. 23, 2011, 3 p.m.








Descripti=
on 

 

 

  
   
With this patch plasmate can now create a CMakeLists.txt.I h=
aven't discussed the patch with someone but i believe that plasmate nee=
ds this feature.

If so,at the publisher there is an install button should i convert it into =
a combobox in order to add the option to install the project using
cmake and not only using plasmapkg.Of course this will be an another patch.

thanks in advance

  		
 






Testing <=
/h1>


 

  
   
the source code is fine,i am not sure about the quality of t=
he CMakeLists.txt file

  		
 








Diffs=
 


    

 
  • publisher/publisher.h (39b1f22)
    • 

 
  • publisher/publisher.cpp (fec24c8)

 
  • templates/CMakeLists.txt (b5f8d2b)<=
/li>





View Diff
--===============8624257035897373716==-- --===============5384450377964889800== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5384450377964889800==--