This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102989/

Ship it!

Ship It!

- Aaron J.


On November 23rd, 2011, 3 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated Nov. 23, 2011, 3 p.m.

Description

With this patch plasmate can now create a CMakeLists.txt.I haven't discussed the patch with someone but i believe that plasmate needs this feature.

If so,at the publisher there is an install button should i convert it into a combobox in order to add the option to install the project using
cmake and not only using plasmapkg.Of course this will be an another patch.

thanks in advance

Testing

the source code is fine,i am not sure about the quality of the CMakeLists.txt file

Diffs

  • publisher/publisher.h (39b1f22)
  • publisher/publisher.cpp (fec24c8)
  • templates/CMakeLists.txt (b5f8d2b)

View Diff