[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make Resize Method selector in Desktop wallpaper
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-27 19:13:04
Message-ID: 20111027191304.21457.44418 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102978/#review7699
-----------------------------------------------------------
a nice idea, though i am concerned this makes the dialog very wide and adds a lot of \
visual clutter.
what could work nicely, however, is to keep the same visual representation but to put \
them into a drop-down box (and keep the text title so people know what it does). \
essentially this would be turning the current textual entries into graphical ones, \
which would be easier for the average person to figure out, i'm sure.
- Aaron J. Seigo
On Oct. 27, 2011, 1:35 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102978/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2011, 1:35 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch changes the generic text-ish dropdown box into six icon'd buttons that \
> let you visually choose your layout, i.e. instead of choosing "Centered" you click \
> on the monitor icon with the KDE logo centered etc. See screenshot for how it \
> looks, I cannot really describe that. There are then six new icons in 128x128 which \
> I attach as zip file. I am not an artist but KolourPaint is awesome ;) Somehow git \
> did not include the CMakeLists.txt in the icons/ subdirectory I created \
> (kde-workspace/plasma/generic/wallpapers/image/icons), although I added it. The \
> CMakeLists.txt file in said directory only contains "KDE4_INSTALL_ICONS( \
> ${ICON_INSTALL_DIR} )" to install the icons.
>
> Diffs
> -----
>
> plasma/generic/wallpapers/image/CMakeLists.txt 2a4c2a3
> plasma/generic/wallpapers/image/image.h 417f5a7
> plasma/generic/wallpapers/image/image.cpp 006a748
> plasma/generic/wallpapers/image/imageconfig.ui 793f0ea
> plasma/generic/wallpapers/image/slideshowconfig.ui 144d437
>
> Diff: http://git.reviewboard.kde.org/r/102978/diff/diff
>
>
> Testing
> -------
>
> Compiles and works.
> Clicking on a resize method button checks this button and after applying the \
> changes, the wallpaper layout changes. Works for both Single Image and Slideshow \
> modes. (Would be nice if the changes were applied right after changing but I \
> couldn't figure out how this is done)
>
> Screenshots
> -----------
>
> Screenshot
> http://git.reviewboard.kde.org/r/102978/s/319/
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102978/">http://git.reviewboard.kde.org/r/102978/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a nice idea, though i am \
concerned this makes the dialog very wide and adds a lot of visual clutter.
what could work nicely, however, is to keep the same visual representation but to put \
them into a drop-down box (and keep the text title so people know what it does). \
essentially this would be turning the current textual entries into graphical ones, \
which would be easier for the average person to figure out, i'm sure.</pre> <br \
/>
<p>- Aaron J.</p>
<br />
<p>On October 27th, 2011, 1:35 p.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2011, 1:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the generic text-ish dropdown box into six icon'd \
buttons that let you visually choose your layout, i.e. instead of choosing \
"Centered" you click on the monitor icon with the KDE logo centered etc. \
See screenshot for how it looks, I cannot really describe that. There are then six \
new icons in 128x128 which I attach as zip file. I am not an artist but KolourPaint \
is awesome ;) Somehow git did not include the CMakeLists.txt in the icons/ \
subdirectory I created (kde-workspace/plasma/generic/wallpapers/image/icons), \
although I added it. The CMakeLists.txt file in said directory only contains \
"KDE4_INSTALL_ICONS( ${ICON_INSTALL_DIR} )" to install the icons.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and works. Clicking on a resize method button checks this \
button and after applying the changes, the wallpaper layout changes. Works for both \
Single Image and Slideshow modes. (Would be nice if the changes were applied right \
after changing but I couldn't figure out how this is done)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/wallpapers/image/CMakeLists.txt <span style="color: \
grey">(2a4c2a3)</span></li>
<li>plasma/generic/wallpapers/image/image.h <span style="color: \
grey">(417f5a7)</span></li>
<li>plasma/generic/wallpapers/image/image.cpp <span style="color: \
grey">(006a748)</span></li>
<li>plasma/generic/wallpapers/image/imageconfig.ui <span style="color: \
grey">(793f0ea)</span></li>
<li>plasma/generic/wallpapers/image/slideshowconfig.ui <span style="color: \
grey">(144d437)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102978/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102978/s/319/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/10/27/newbgselector_400x100.png" \
style="border: 1px black solid;" alt="Screenshot" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic