[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Escape Text in Microblogging Post Widget
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-27 19:08:56
Message-ID: 20111027190856.21294.11435 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 26, 2011, 2:51 p.m., Aaron J. Seigo wrote:
> > Ship It!
> =
> David Narv=C3=A1ez wrote:
> What's the commit schema? master then 4.7?
for bugfixes, usually 4.7 branch (or whatever the stable branch is) then a =
git merge to master if it the module is mergeable (i forget if addons is; i=
t might be like kde-workspace and never had that straightened out) in which=
case a git cherry-pick will suffice.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102973/#review7661
-----------------------------------------------------------
On Oct. 26, 2011, 1:04 p.m., David Narv=C3=A1ez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102973/
> -----------------------------------------------------------
> =
> (Updated Oct. 26, 2011, 1:04 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Cleanup some html entities before inserting text in the post widget.
> =
> =
> Diffs
> -----
> =
> applets/microblog/postwidget.cpp 08e3ff9 =
> =
> Diff: http://git.reviewboard.kde.org/r/102973/diff/diff
> =
> =
> Testing
> -------
> =
> Try denting "I <3 KDE". Before this patch, you should only see "I" in the=
post widget. This patch cleans "<" as "<" and you should see "I <3 KDE"=
in the widget.
> =
> =
> Thanks,
> =
> David Narv=C3=A1ez
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102973/">http://git.reviewboard.kde.org/r/102973/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 26th, 2011, 2:51 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On October 27th, 2011, 2:29 a.m., <b>David Narváez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the commit \
schema? master then 4.7?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for bugfixes, usually \
4.7 branch (or whatever the stable branch is) then a git merge to master if it the \
module is mergeable (i forget if addons is; it might be like kde-workspace and never \
had that straightened out) in which case a git cherry-pick will suffice.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On October 26th, 2011, 1:04 p.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2011, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cleanup some html entities before inserting text in the post \
widget.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Try denting "I <3 KDE". Before this patch, you should only \
see "I" in the post widget. This patch cleans "<" as \
"&lt;" and you should see "I <3 KDE" in the widget.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/microblog/postwidget.cpp <span style="color: grey">(08e3ff9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102973/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic