This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102978/ 

a nice idea, though i am concerned this makes the dialog very wide and adds a lot of visual clutter.

what could work nicely, however, is to keep the same visual representation but to put them into a drop-down box (and keep the text title so people know what it does). essentially this would be turning the current textual entries into graphical ones, which would be easier for the average person to figure out, i'm sure.

- Aaron J.


On October 27th, 2011, 1:35 p.m., Kai Uwe Broulik wrote:

Review request for Plasma.
By Kai Uwe Broulik.

Updated Oct. 27, 2011, 1:35 p.m.

Description 

This patch changes the generic text-ish dropdown box into six icon'd buttons that let you visually choose your layout, i.e. instead of choosing "Centered" you click on the monitor icon with the KDE logo centered etc. See screenshot for how it looks, I cannot really describe that.
There are then six new icons in 128x128 which I attach as zip file. I am not an artist but KolourPaint is awesome ;)
Somehow git did not include the CMakeLists.txt in the icons/ subdirectory I created (kde-workspace/plasma/generic/wallpapers/image/icons), although I added it. The CMakeLists.txt file in said directory only contains "KDE4_INSTALL_ICONS( ${ICON_INSTALL_DIR} )" to install the icons.

Testing 

Compiles and works.
Clicking on a resize method button checks this button and after applying the changes, the wallpaper layout changes. Works for both Single Image and Slideshow modes.
(Would be nice if the changes were applied right after changing but I couldn’t figure out how this is done)

Diffs

  • plasma/generic/wallpapers/image/CMakeLists.txt (2a4c2a3)
  • plasma/generic/wallpapers/image/image.h (417f5a7)
  • plasma/generic/wallpapers/image/image.cpp (006a748)
  • plasma/generic/wallpapers/image/imageconfig.ui (793f0ea)
  • plasma/generic/wallpapers/image/slideshowconfig.ui (144d437)

View Diff

Screenshots

Screenshot