[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: picture frame widget - open potd picture
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-27 19:06:41
Message-ID: 20111027190641.21181.15089 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 25, 2011, 11:35 a.m., Aaron J. Seigo wrote:
> > applets/frame/slideshow.cpp, lines 221-222
> > <http://git.reviewboard.kde.org/r/102817/diff/1/?file=38475#file38475line221>
> >
> > much cleaner than this, which introduces an assumption on where potd stores \
> > things into the widget, would be add a URL item in the potd DataEngine that is \
> > included with the source. this could be either a remote or a local URL and \
> > wouldn't require the applet to be changed if/when the DataEngine changes.
>
> Greg T wrote:
> Well, I get the basic idea but can you try to explain it a little bit more in \
> detail? I suppose I should make a change in \
> kdeplasma-addons/dataengines/potd/potd.cpp?
yes, a change in the dataengine .. so that when it doest setData( \
provider->identifier(), provider->image() ) it will also do a \
setData(provider->identifier(), "URL", someUrlToTheImage)
in fact, i'd even change that first setData to be setData(rovider->identifier(), \
"Image", provider->image()) and then change the plasmoid to work with that. if there \
were other potential users of this dataengine, it could also be moved into \
kde-workspace (i could imagine a wallpaper using it, for instance :)
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102817/#review7597
-----------------------------------------------------------
On Oct. 10, 2011, 10:41 a.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102817/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2011, 10:41 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hi,
> This fix passes m_currentUrl the correct file path, so the downloaded picture will \
> be opened by the picture viewer (gwenview).
>
> This addresses bug 280406.
> http://bugs.kde.org/show_bug.cgi?id=280406
>
>
> Diffs
> -----
>
> applets/frame/slideshow.cpp 116c514
>
> Diff: http://git.reviewboard.kde.org/r/102817/diff/diff
>
>
> Testing
> -------
>
> Bug fixed.
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102817/">http://git.reviewboard.kde.org/r/102817/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2011, 11:35 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102817/diff/1/?file=38475#file38475line221" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/frame/slideshow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
SlideShow::dataUpdated(const QString &name, const Plasma::DataEngine::Data \
&data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">221</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_currentUrl</span> <span class="o">=</span> <span \
class="n">KStandardDirs</span><span class="o">::</span><span \
class="n">locate</span><span class="p">(</span><span \
class="s">"data"</span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">222</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"plasma_engine_podt/"</span> <span class="o">+</span> <span \
class="n">name</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">much cleaner than this, \
which introduces an assumption on where potd stores things into the widget, would be \
add a URL item in the potd DataEngine that is included with the source. this could be \
either a remote or a local URL and wouldn't require the applet to be changed \
if/when the DataEngine changes.</pre> </blockquote>
<p>On October 27th, 2011, 4:25 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I get the basic \
idea but can you try to explain it a little bit more in detail? I suppose I should \
make a change in kdeplasma-addons/dataengines/potd/potd.cpp?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, a \
change in the dataengine .. so that when it doest setData( provider->identifier(), \
provider->image() ) it will also do a setData(provider->identifier(), \
"URL", someUrlToTheImage)
in fact, i'd even change that first setData to be \
setData(rovider->identifier(), "Image", provider->image()) and then \
change the plasmoid to work with that. if there were other potential users of this \
dataengine, it could also be moved into kde-workspace (i could imagine a wallpaper \
using it, for instance :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On October 10th, 2011, 10:41 a.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2011, 10:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, This fix passes m_currentUrl the correct file path, so the \
downloaded picture will be opened by the picture viewer (gwenview). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug fixed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=280406">280406</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/frame/slideshow.cpp <span style="color: grey">(116c514)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic