'Re: Review Request: The tooltip's tag are mismatch on krandrtray'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: The tooltip's tag are mismatch on krandrtray
From:       "Commit Hook" <null () kde ! org>
Date:       2011-05-25 7:29:26
Message-ID: 20110525072926.31346.51817 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101430/#review3500
-----------------------------------------------------------

This review has been submitted with commit 7b7a9512d73312712e99d5fb082dfb4d=
7575d6e9 by Max Lin.

- Commit

On May 24, 2011, 2:55 p.m., Max Lin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101430/
> -----------------------------------------------------------
> =

> (Updated May 24, 2011, 2:55 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> After launch krandrtray, move cursor up on krandrtray, it will shows tool=
tip, however, looks the tag are not match so caused context are not aligned=
, and text color are not consistent, we also can catch the "tag mismatch" d=
ebug message. I added "<tr>" tag to match with "</tr>" tag, after with this=
 patch, the "tag mismatch" message disappear.
> =

> =

> Diffs
> -----
> =

>   kcontrol/randr/krandrtray.cpp aab7295 =

> =

> Diff: http://git.reviewboard.kde.org/r/101430/diff
> =

> =

> Testing
> -------
> =

> Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screensho=
t before/after with this patch.
> =

> =

> Screenshots
> -----------
> =

> tag mismatch
>   http://git.reviewboard.kde.org/r/101430/s/172/
> tag match
>   http://git.reviewboard.kde.org/r/101430/s/173/
> =

> =

> Thanks,
> =

> Max
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101430/">http://git.reviewboard.kde.org/r/101430/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7b7a9512d73312712e99d5fb082dfb4d7575d6e9 by Max Lin.</pre>  <br \
/>

<p>- Commit</p>

<br />
<p>On May 24th, 2011, 2:55 p.m., Max Lin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Max Lin.</div>

<p style="color: grey;"><i>Updated May 24, 2011, 2:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After launch krandrtray, move cursor up on krandrtray, it will shows \
tooltip, however, looks the tag are not match so caused context are not aligned, and \
text color are not consistent, we also can catch the &quot;tag mismatch&quot; debug \
message. I added &quot;&lt;tr&gt;&quot; tag to match with &quot;&lt;/tr&gt;&quot; \
tag, after with this patch, the &quot;tag mismatch&quot; message disappear.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached \
screenshot before/after with this patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/randr/krandrtray.cpp <span style="color: grey">(aab7295)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101430/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/101430/s/172/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/24/krandrtray_before_400x100.png" \
style="border: 1px black solid;" alt="tag mismatch" /></a>

 <a href="http://git.reviewboard.kde.org/r/101430/s/173/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/24/krandrtray_after_400x100.png" \
style="border: 1px black solid;" alt="tag match" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 