--===============1496067734== Content-Type: multipart/alternative; boundary="===============5736958861705355110==" --===============5736958861705355110== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/#review3500 ----------------------------------------------------------- This review has been submitted with commit 7b7a9512d73312712e99d5fb082dfb4d= 7575d6e9 by Max Lin. - Commit On May 24, 2011, 2:55 p.m., Max Lin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101430/ > ----------------------------------------------------------- > = > (Updated May 24, 2011, 2:55 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > After launch krandrtray, move cursor up on krandrtray, it will shows tool= tip, however, looks the tag are not match so caused context are not aligned= , and text color are not consistent, we also can catch the "tag mismatch" d= ebug message. I added "" tag to match with "" tag, after with this= patch, the "tag mismatch" message disappear. > = > = > Diffs > ----- > = > kcontrol/randr/krandrtray.cpp aab7295 = > = > Diff: http://git.reviewboard.kde.org/r/101430/diff > = > = > Testing > ------- > = > Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screensho= t before/after with this patch. > = > = > Screenshots > ----------- > = > tag mismatch > http://git.reviewboard.kde.org/r/101430/s/172/ > tag match > http://git.reviewboard.kde.org/r/101430/s/173/ > = > = > Thanks, > = > Max > = > --===============5736958861705355110== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101430/ 

This revie=
w has been submitted with commit 7b7a9512d73312712e99d5fb082dfb4d7575d6e9 b=
y Max Lin.

- Commit


On May 24th, 2011, 2:55 p.m., Max Lin wrote:

Review request for Plasma.
By Max Lin.

Updated May 24, 2011, 2:55 p.m.

Descripti= on 

After launch krandrtray, move cursor up on krandrtray, it wi=
ll shows tooltip, however, looks the tag are not match so caused context ar=
e not aligned, and text color are not consistent, we also can catch the &qu=
ot;tag mismatch" debug message. I added "<tr>" tag to =
match with "</tr>" tag, after with this patch, the "ta=
g mismatch" message disappear.

Testing <= /h1> 
Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attac=
hed screenshot before/after with this patch.

Diffs=

  • kcontrol/randr/krandrtray.cpp (aab7295)

View Diff

Screensho= ts

--===============5736958861705355110==-- --===============1496067734== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1496067734==--