'Review Request: Make the timer plasmoid text-based rather than'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Make the timer plasmoid text-based rather than
From:       "Tadeusz Andrzej Kadlubowski" <yess () hell ! org ! pl>
Date:       2011-01-28 16:56:57
Message-ID: 20110128165657.17312.60977 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6420/
-----------------------------------------------------------

Review request for Plasma and Davide Bettio.

Summary
-------

Currently the timer plasmoid uses prerendered fonts packaged as a SVG theme=
. This ignores user preferences related to fonts, and looks out of place, w=
hen this plasmoid is used just next to a digital clock plasmoid.

The goal of this patch is to make this plasmoid look the same as the timer =
plasmoid. Uniformity is a nice polish.

This is a work in progress. TODOs:
- Font sizing is not ready;
- The SVG theme is to be thrown away;
- Font choice in the configuration dialog.

Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/timer/timer.h 1217778 =

  /trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1217778 =

  /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.h 1217778 =

  /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.cpp 1217778 =

Diff: http://svn.reviewboard.kde.org/r/6420/diff

Testing
-------

Compiles cleanly. Works well on KDE 4.5.4.

Setting timer with scroll wheel still works.
Changing color to red still works.
Notifications still work.

Thanks,

Tadeusz Andrzej

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6420/">http://svn.reviewboard.kde.org/r/6420/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Davide Bettio.</div>
<div>By Tadeusz Andrzej Kadlubowski.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the timer plasmoid uses prerendered fonts packaged as a SVG \
theme. This ignores user preferences related to fonts, and looks out of place, when \
this plasmoid is used just next to a digital clock plasmoid.

The goal of this patch is to make this plasmoid look the same as the timer plasmoid. \
Uniformity is a nice polish.

This is a work in progress. TODOs:
- Font sizing is not ready;
- The SVG theme is to be thrown away;
- Font choice in the configuration dialog.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles cleanly. Works well on KDE 4.5.4.

Setting timer with scroll wheel still works.
Changing color to red still works.
Notifications still work.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timer.h <span style="color: \
grey">(1217778)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp <span style="color: \
grey">(1217778)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.h <span style="color: \
grey">(1217778)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.cpp <span style="color: \
grey">(1217778)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6420/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 