From kde-panel-devel Fri Jan 28 16:56:57 2011 From: "Tadeusz Andrzej Kadlubowski" Date: Fri, 28 Jan 2011 16:56:57 +0000 To: kde-panel-devel Subject: Review Request: Make the timer plasmoid text-based rather than Message-Id: <20110128165657.17312.60977 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129623458809820 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0289425193==" --===============0289425193== Content-Type: multipart/alternative; boundary="===============3080634796690975548==" --===============3080634796690975548== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6420/ ----------------------------------------------------------- Review request for Plasma and Davide Bettio. Summary ------- Currently the timer plasmoid uses prerendered fonts packaged as a SVG theme= . This ignores user preferences related to fonts, and looks out of place, w= hen this plasmoid is used just next to a digital clock plasmoid. The goal of this patch is to make this plasmoid look the same as the timer = plasmoid. Uniformity is a nice polish. This is a work in progress. TODOs: - Font sizing is not ready; - The SVG theme is to be thrown away; - Font choice in the configuration dialog. Diffs ----- /trunk/KDE/kdeplasma-addons/applets/timer/timer.h 1217778 = /trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1217778 = /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.h 1217778 = /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.cpp 1217778 = Diff: http://svn.reviewboard.kde.org/r/6420/diff Testing ------- Compiles cleanly. Works well on KDE 4.5.4. Setting timer with scroll wheel still works. Changing color to red still works. Notifications still work. Thanks, Tadeusz Andrzej --===============3080634796690975548== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6420/

Review request for Plasma and Davide Bettio.

By Tadeusz Andrzej Kadlubowski.

Descripti= on

Currently the timer plasmoid uses prerendered fonts packaged=
 as a SVG theme. This ignores user preferences related to fonts, and looks =
out of place, when this plasmoid is used just next to a digital clock plasm=
oid.

The goal of this patch is to make this plasmoid look the same as the timer =
plasmoid. Uniformity is a nice polish.

This is a work in progress. TODOs:
- Font sizing is not ready;
- The SVG theme is to be thrown away;
- Font choice in the configuration dialog.

Testing <= /h1>

Compiles cleanly. Works well on KDE 4.5.4.

Setting timer with scroll wheel still works.
Changing color to red still works.
Notifications still work.

Diffs=

/trunk/KDE/kdeplasma-addons/applets/timer/timer.h (1217778)
/trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp (1217778)
/trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.h (1217778)
/trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.cpp (1217778)

--===============3080634796690975548==-- --===============0289425193== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0289425193==--