[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Identify SVGs that use system colors with
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-12-18 0:44:49
Message-ID: 20101218004449.28583.14448 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6150/#review9298
-----------------------------------------------------------
Ship it!
/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/6150/#comment10183>
const?
/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/6150/#comment10182>
may as well make it const
- Aaron
On 2010-12-17 21:30:29, Manuel Mommertz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6150/
> -----------------------------------------------------------
> =
> (Updated 2010-12-17 21:30:29)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> The function 'checkColorHints' looks if the bounding rect of the element =
with the id 'current-color-scheme' is valid. This always fails because this=
element is a stylesheet and therefore has no rect.
> I abstracted the possibility to identify size hints on svg-loading so tha=
t it now allows the SharedSvgRenderer to insert interesting elements in the=
themes rect cache. This is used for the size hints and to insert a valid r=
ect for 'current-color-scheme'.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/private/svg_p.h 1206760 =
> /trunk/KDE/kdelibs/plasma/svg.cpp 1206760 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6150/diff
> =
> =
> Testing
> -------
> =
> Switching themes, switching colors, switching compositing
> =
> =
> Thanks,
> =
> Manuel
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6150/">http://svn.reviewboard.kde.org/r/6150/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6150/diff/2/?file=42682#file42682line463" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/plasma/svg.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
SvgPrivate::createRenderer()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">434</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">cacheId</span> <span class="o">=</span> \
<span class="n">CACHE_ID_NATURAL_SIZE</span><span class="p">(</span><span \
class="n"><span class="hl">fullE</span>lementId</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">435</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> \
<span class="n">cacheId</span> <span class="o">=</span> <span \
class="n">CACHE_ID_NATURAL_SIZE</span><span class="p">(</span><span class="n"><span \
class="hl">e</span>lementId</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">const?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6150/diff/2/?file=42682#file42682line536" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/plasma/svg.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QRectF \
SvgPrivate::elementRect(const QString &elementId)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">500</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">id</span> <span class="o">=</span> <span \
class="n">cacheId</span><span class="p">(</span><span class="n">elementId</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">may as well \
make it const</pre> </div>
<br />
<p>- Aaron</p>
<br />
<p>On December 17th, 2010, 9:30 p.m., Manuel Mommertz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Manuel Mommertz.</div>
<p style="color: grey;"><i>Updated 2010-12-17 21:30:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The function 'checkColorHints' looks if the bounding rect of the \
element with the id 'current-color-scheme' is valid. This always fails \
because this element is a stylesheet and therefore has no rect. I abstracted the \
possibility to identify size hints on svg-loading so that it now allows the \
SharedSvgRenderer to insert interesting elements in the themes rect cache. This is \
used for the size hints and to insert a valid rect for \
'current-color-scheme'.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switching themes, switching colors, switching compositing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/private/svg_p.h <span style="color: \
grey">(1206760)</span></li>
<li>/trunk/KDE/kdelibs/plasma/svg.cpp <span style="color: \
grey">(1206760)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6150/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic