From kde-panel-devel Sat Dec 18 00:44:49 2010 From: "Aaron Seigo" Date: Sat, 18 Dec 2010 00:44:49 +0000 To: kde-panel-devel Subject: Re: Review Request: Identify SVGs that use system colors with Message-Id: <20101218004449.28583.14448 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129263312808085 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1849144208==" --===============1849144208== Content-Type: multipart/alternative; boundary="===============3494583046548373631==" --===============3494583046548373631== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6150/#review9298 ----------------------------------------------------------- Ship it! /trunk/KDE/kdelibs/plasma/svg.cpp const? /trunk/KDE/kdelibs/plasma/svg.cpp may as well make it const - Aaron On 2010-12-17 21:30:29, Manuel Mommertz wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6150/ > ----------------------------------------------------------- > = > (Updated 2010-12-17 21:30:29) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > The function 'checkColorHints' looks if the bounding rect of the element = with the id 'current-color-scheme' is valid. This always fails because this= element is a stylesheet and therefore has no rect. > I abstracted the possibility to identify size hints on svg-loading so tha= t it now allows the SharedSvgRenderer to insert interesting elements in the= themes rect cache. This is used for the size hints and to insert a valid r= ect for 'current-color-scheme'. > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/plasma/private/svg_p.h 1206760 = > /trunk/KDE/kdelibs/plasma/svg.cpp 1206760 = > = > Diff: http://svn.reviewboard.kde.org/r/6150/diff > = > = > Testing > ------- > = > Switching themes, switching colors, switching compositing > = > = > Thanks, > = > Manuel > = > --===============3494583046548373631== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6150/

Ship it!

= =
/trunk/KDE/kdelibs/plasma/svg.cpp (Diff revision 2) 
void SvgPrivate::createRenderer()
434 
                QString cacheId =3D CACHE_ID_NATURAL_SIZE(fullElementId);
 435 
                QString cacheId =3D CACHE_ID_NATURAL_SIZE(elementId);
 
const?

= =
/trunk/KDE/kdelibs/plasma/svg.cpp (Diff revision 2) 
QRectF SvgPrivate::elementRect(const QString &elementId)
<= /td> 

    500
    
    QString id =3D cacheId(elementId);

  


 





may as well make it const









- Aaron






On December 17th, 2010, 9:30 p.m., Manuel Mommertz wrote:









 

  


Review request for Plasma.


By Manuel Mommertz.




Updated 2010-12-17 21:30:29






Descripti=
on 



 

  
   
The function 'checkColorHints' looks if the bounding=
 rect of the element with the id 'current-color-scheme' is valid. T=
his always fails because this element is a stylesheet and therefore has no =
rect.
I abstracted the possibility to identify size hints on svg-loading so that =
it now allows the SharedSvgRenderer to insert interesting elements in the t=
hemes rect cache. This is used for the size hints and to insert a valid rec=
t for 'current-color-scheme'.

  		
 






Testing <=
/h1>


 

  
   
Switching themes, switching colors, switching compositing
  

 








Diffs=
 


    

 
  • /trunk/KDE/kdelibs/plasma/private/svg_p.h =
(1206760)
    • 

 
  • /trunk/KDE/kdelibs/plasma/svg.cpp (1206760=
)
    • 





View Diff





  		
 











  

 



--===============3494583046548373631==--

--===============1849144208==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1849144208==--