This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6150/

Ship it!

/trunk/KDE/kdelibs/plasma/svg.cpp (Diff revision 2)
void SvgPrivate::createRenderer()
434	QString cacheId = CACHE_ID_NATURAL_SIZE(fullElementId);	435	QString cacheId = CACHE_ID_NATURAL_SIZE(elementId);

const?

/trunk/KDE/kdelibs/plasma/svg.cpp (Diff revision 2)
QRectF SvgPrivate::elementRect(const QString &elementId)
		500	QString id = cacheId(elementId);

may as well make it const

- Aaron

On December 17th, 2010, 9:30 p.m., Manuel Mommertz wrote:

Review request for Plasma.

By Manuel Mommertz.

Updated 2010-12-17 21:30:29

Description

The function 'checkColorHints' looks if the bounding rect of the element with the id 'current-color-scheme' is valid. This always fails because this element is a stylesheet and therefore has no rect.
I abstracted the possibility to identify size hints on svg-loading so that it now allows the SharedSvgRenderer to insert interesting elements in the themes rect cache. This is used for the size hints and to insert a valid rect for 'current-color-scheme'.

Testing

Switching themes, switching colors, switching compositing

Diffs

/trunk/KDE/kdelibs/plasma/private/svg_p.h (1206760)
/trunk/KDE/kdelibs/plasma/svg.cpp (1206760)

View Diff