[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Notes widget: Working
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2010-11-30 15:16:35
Message-ID: 20101130151635.2596.63169 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9051
-----------------------------------------------------------
Ship it!
Have you tried removing the space again after you've changed the font? That=
way it would be transparent I think.
Otherwise, patch is OK from my POV. When you've filed a Qt bug, please put =
a reference URL to it in the code, as it's a bit "unusual" and easier to ke=
ep track that way.
trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp
<http://svn.reviewboard.kde.org/r/6005/#comment9845>
use toPlainText().isEmpty() here
- Sebastian
On 2010-11-28 20:23:45, Davide Bettio wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
> =
> (Updated 2010-11-28 20:23:45)
> =
> =
> Review request for Plasma and Stephen Kelly.
> =
> =
> Summary
> -------
> =
> Text format of the note can't be changed while the note is empty, so I ad=
d a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review reque=
st also steveire.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Davide
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6005/">http://svn.reviewboard.kde.org/r/6005/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you tried removing \
the space again after you've changed the font? That way it would be transparent I \
think.
Otherwise, patch is OK from my POV. When you've filed a Qt bug, please put a \
reference URL to it in the code, as it's a bit "unusual" and easier to \
keep track that way.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6005/diff/1/?file=41820#file41820line85" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NotesTextEdit::addSpaceToEmptyNotes()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">85</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">toPlainText</span><span \
class="p">()</span> <span class="o">==</span> <span \
class="s">""</span><span class="p">){</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use \
toPlainText().isEmpty() here</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On November 28th, 2010, 8:23 p.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Stephen Kelly.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated 2010-11-28 20:23:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Text format of the note can't be changed while the note is empty, so \
I add a space and I change the text format. This work around is rather stupid but I \
don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add \
to this review request also steveire. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.h <span style="color: \
grey">(1201054)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <span style="color: \
grey">(1201054)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic