[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Notes widget: Working
From: "Anne-Marie Mahfouf" <annma () kde ! org>
Date: 2010-12-04 16:21:05
Message-ID: 20101204162105.4119.75179 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6005/#review9126
-----------------------------------------------------------
The bug is in the Notes code. It you remove lines 412 - 417 from notes.cpp =
you can see that you can set the text marking correctly on the first letter=
. I hope the patch was not applied because we don't want to make the code m=
ore confusing...
- Anne-Marie
On 2010-11-28 20:23:45, Davide Bettio wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6005/
> -----------------------------------------------------------
> =
> (Updated 2010-11-28 20:23:45)
> =
> =
> Review request for Plasma and Stephen Kelly.
> =
> =
> Summary
> -------
> =
> Text format of the note can't be changed while the note is empty, so I ad=
d a space and I change the text format.
> This work around is rather stupid but I don't have any nicer idea.
> Anyway this might be a bug in KRichTextEdit so I add to this review reque=
st also steveire.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 =
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6005/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Davide
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6005/">http://svn.reviewboard.kde.org/r/6005/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bug is in the Notes \
code. It you remove lines 412 - 417 from notes.cpp you can see that you can set the \
text marking correctly on the first letter. I hope the patch was not applied because \
we don't want to make the code more confusing...</pre> <br />
<p>- Anne-Marie</p>
<br />
<p>On November 28th, 2010, 8:23 p.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Stephen Kelly.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated 2010-11-28 20:23:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Text format of the note can't be changed while the note is empty, so \
I add a space and I change the text format. This work around is rather stupid but I \
don't have any nicer idea. Anyway this might be a bug in KRichTextEdit so I add \
to this review request also steveire. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.h <span style="color: \
grey">(1201054)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <span style="color: \
grey">(1201054)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic