From kde-panel-devel Tue Nov 30 15:16:35 2010 From: =?utf-8?q?Sebastian_K=C3=BCgler?= Date: Tue, 30 Nov 2010 15:16:35 +0000 To: kde-panel-devel Subject: Re: Review Request: Notes widget: Working Message-Id: <20101130151635.2596.63169 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=129113031424450 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1360338215==" --===============1360338215== Content-Type: multipart/alternative; boundary="===============3656051209325897958==" --===============3656051209325897958== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9051 ----------------------------------------------------------- Ship it! Have you tried removing the space again after you've changed the font? That= way it would be transparent I think. Otherwise, patch is OK from my POV. When you've filed a Qt bug, please put = a reference URL to it in the code, as it's a bit "unusual" and easier to ke= ep track that way. trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp use toPlainText().isEmpty() here - Sebastian On 2010-11-28 20:23:45, Davide Bettio wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6005/ > ----------------------------------------------------------- > = > (Updated 2010-11-28 20:23:45) > = > = > Review request for Plasma and Stephen Kelly. > = > = > Summary > ------- > = > Text format of the note can't be changed while the note is empty, so I ad= d a space and I change the text format. > This work around is rather stupid but I don't have any nicer idea. > Anyway this might be a bug in KRichTextEdit so I add to this review reque= st also steveire. > = > = > Diffs > ----- > = > trunk/KDE/kdeplasma-addons/applets/notes/notes.h 1201054 = > trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 1201054 = > = > Diff: http://svn.reviewboard.kde.org/r/6005/diff > = > = > Testing > ------- > = > = > Thanks, > = > Davide > = > --===============3656051209325897958== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6005/

Ship it!

Have you t=
ried removing the space again after you've changed the font? That way i=
t would be transparent I think.

Otherwise, patch is OK from my POV. When you've filed a Qt bug, please =
put a reference URL to it in the code, as it's a bit "unusual"=
; and easier to keep track that way.

= =

trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp (Diff revision 1)
	void NotesTextEdit::addSpaceToEmptyNotes()
		85	if (toPlainText()= =3D=3D ""){

use toPlainText().isEmpty() here

- Sebastian

On November 28th, 2010, 8:23 p.m., Davide Bettio wrote:

Review request for Plasma and Stephen Kelly.

By Davide Bettio.

Updated 2010-11-28 20:23:45

Descripti= on

Text format of the note can't be changed while the note =
is empty, so I add a space and I change the text format.
This work around is rather stupid but I don't have any nicer idea.
Anyway this might be a bug in KRichTextEdit so I add to this review request=
 also steveire.

Diffs=

trunk/KDE/kdeplasma-addons/applets/notes/notes.h (1201054)
trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp (1201054)

--===============3656051209325897958==-- --===============1360338215== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1360338215==--