'Re: Review Request: Corona::exportLayout'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Corona::exportLayout
From:       "Chani Armitage" <chanika () gmail ! com>
Date:       2010-09-27 14:38:42
Message-ID: 20100927143842.30202.26925 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5451/
-----------------------------------------------------------

(Updated 2010-09-27 14:38:42.056313)

Review request for Plasma.

Changes
-------

updated API and fixed the immutability thing

Summary
-------

this adds exportLayout to corona, which saves a group of containments to a =
config file and deletes them from the main config.

Activity::close() becomes a lot shorter by calling it, like this: m_corona-=
>exportLayout(external, m_containments.values());

I feel a bit out of it today though, so tell me if I've missed anything obv=
ious...

Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/corona.h 1179499 =

  trunk/KDE/kdelibs/plasma/corona.cpp 1179499 =

Diff: http://svn.reviewboard.kde.org/r/5451/diff

Testing
-------

closing an activity while locked is perfectly safe now :)

Thanks,

Chani

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5451/">http://svn.reviewboard.kde.org/r/5451/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Chani Armitage.</div>

<p style="color: grey;"><i>Updated 2010-09-27 14:38:42.056313</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">updated API and fixed the immutability thing</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this adds exportLayout to corona, which saves a group of containments to \
a config file and deletes them from the main config.

Activity::close() becomes a lot shorter by calling it, like this: \
m_corona-&gt;exportLayout(external, m_containments.values());

I feel a bit out of it today though, so tell me if I&#39;ve missed anything \
obvious...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">closing an activity while locked is perfectly safe now :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/corona.h <span style="color: \
grey">(1179499)</span></li>

 <li>trunk/KDE/kdelibs/plasma/corona.cpp <span style="color: \
grey">(1179499)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5451/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 