[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: transient extenderitems
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2010-07-23 18:36:58
Message-ID: 20100723183658.22247.73260 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4758/#review6694
-----------------------------------------------------------
Ship it!
neat hack; you should probably add some code comments explaining what is go=
ing on in the .cpp file as it isn't clear on first glance. otherwise, with =
the one comment below address, ship it. :)
/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h
<http://reviewboard.kde.org/r/4758/#comment6474>
needs apidox and a const getter
- Aaron
On 2010-07-23 18:05:03, Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4758/
> -----------------------------------------------------------
> =
> (Updated 2010-07-23 18:05:03)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> another of those things that doesn't feel right, but feels that current u=
se cases kinda requires something like that:
> =
> dd an option in extenderitem to use a config group completely in memory, =
intended for extenderitems that really aren't supposed to be saved and rest=
ored on disk.
> the notifications one, but more important the job ones really don't have =
a big point to be saved.
> at the moment they are cleaned out at exit, but sometimes stay in the con=
fig file after a plasma crash
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdelibs/plasma/extenders/extenderitem.h 1153063 =
> /trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1153063 =
> =
> Diff: http://reviewboard.kde.org/r/4758/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4758/">http://reviewboard.kde.org/r/4758/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>neat hack; you should probably add some code comments explaining what is going \
on in the .cpp file as it isn't clear on first glance. otherwise, with the one \
comment below address, ship it. :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/4758/diff/1/?file=31838#file31838line239" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">class PLASMA_EXPORT ExtenderItem : \
public QGraphicsWidget</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">239</font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;"> \
<span class="kt">void</span> <span class="n">setTransient</span><span \
class="p">(</span><span class="k">const</span> <span class="n">bool</span> <span \
class="n">transient</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em">needs apidox and a const getter</pre>
</div>
<br />
<p>- Aaron</p>
<br />
<p>On July 23rd, 2010, 6:05 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated 2010-07-23 18:05:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">another of those things that doesn't feel \
right, but feels that current use cases kinda requires something like that:
dd an option in extenderitem to use a config group completely in memory, intended for \
extenderitems that really aren't supposed to be saved and restored on disk. the \
notifications one, but more important the job ones really don't have a big point \
to be saved. at the moment they are cleaned out at exit, but sometimes stay in the \
config file after a plasma crash</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h <span style="color: \
grey">(1153063)</span></li>
<li>/trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: \
grey">(1153063)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4758/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic