--===============1862789148== Content-Type: multipart/alternative; boundary="===============6722497440731140476==" --===============6722497440731140476== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4758/#review6694 ----------------------------------------------------------- Ship it! neat hack; you should probably add some code comments explaining what is go= ing on in the .cpp file as it isn't clear on first glance. otherwise, with = the one comment below address, ship it. :) /trunk/KDE/kdelibs/plasma/extenders/extenderitem.h needs apidox and a const getter - Aaron On 2010-07-23 18:05:03, Marco Martin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4758/ > ----------------------------------------------------------- > = > (Updated 2010-07-23 18:05:03) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > another of those things that doesn't feel right, but feels that current u= se cases kinda requires something like that: > = > dd an option in extenderitem to use a config group completely in memory, = intended for extenderitems that really aren't supposed to be saved and rest= ored on disk. > the notifications one, but more important the job ones really don't have = a big point to be saved. > at the moment they are cleaned out at exit, but sometimes stay in the con= fig file after a plasma crash > = > = > Diffs > ----- > = > /trunk/KDE/kdelibs/plasma/extenders/extenderitem.h 1153063 = > /trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1153063 = > = > Diff: http://reviewboard.kde.org/r/4758/diff > = > = > Testing > ------- > = > = > Thanks, > = > Marco > = > --===============6722497440731140476== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4758/

Ship it!

neat hack; you should probably add some code comments explaining what=
 is going on in the .cpp file as it isn't clear on first glance. otherw=
ise, with the one comment below address, ship it. :)

= =

/trunk/KDE/kdelib= s/plasma/extenders/extenderitem.h (Diff revision 1)
class PLASMA_EXPORT Ex= tenderItem : public QGraphicsWidget
	<= /pre>	239	= void setTransient= (const = bool transient);

needs apidox and a const getter

- Aaron

On July 23rd, 2010, 6:05 p.m., Marco Martin wrote:

Review request for Plasma.

By Marco Martin.

Updated 2010-07-23 18:05:03

Descripti= on

another of those things that doesn=
't feel right, but feels that current use cases kinda requires somethin=
g like that:

dd an option in extenderitem to use a config group completely in memory, in=
tended for extenderitems that really aren't supposed to be saved and re=
stored on disk.
the notifications one, but more important the job ones really don't hav=
e a big point to be saved.
at the moment they are cleaned out at exit, but sometimes stay in the confi=
g file after a plasma crash

Diffs=

/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h (1153063)
/trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp (1153063)

--===============6722497440731140476==-- --===============1862789148== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1862789148==--