'Review Request: transient extenderitems'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: transient extenderitems
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2010-07-23 18:05:03
Message-ID: 20100723180503.21828.16570 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4758/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

another of those things that doesn't feel right, but feels that current use=
 cases kinda requires something like that:

dd an option in extenderitem to use a config group completely in memory, in=
tended for extenderitems that really aren't supposed to be saved and restor=
ed on disk.
the notifications one, but more important the job ones really don't have a =
big point to be saved.
at the moment they are cleaned out at exit, but sometimes stay in the confi=
g file after a plasma crash

Diffs
-----

  /trunk/KDE/kdelibs/plasma/extenders/extenderitem.h 1153063 =

  /trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1153063 =

Diff: http://reviewboard.kde.org/r/4758/diff

Testing
-------

Thanks,

Marco

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4758/">http://reviewboard.kde.org/r/4758/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">another of those things that doesn&#39;t feel \
right, but feels that current use cases kinda requires something like that:

dd an option in extenderitem to use a config group completely in memory, intended for \
extenderitems that really aren&#39;t supposed to be saved and restored on disk. the \
notifications one, but more important the job ones really don&#39;t have a big point \
to be saved. at the moment they are cleaned out at exit, but sometimes stay in the \
config file after a plasma crash</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h <span style="color: \
grey">(1153063)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp <span style="color: \
grey">(1153063)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4758/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 