[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: new KWin effect: Dashboard
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-07-23 15:48:54
Message-ID: 20100723154854.17992.97981 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/#review6689
-----------------------------------------------------------
Ship it!
At least for KWin part this is a ship It. If nobody comments on the plasma part, just \
go ahead. Btw there are a few red markings in the diff.
- Martin
On 2010-07-21 13:52:16, Andreas Demmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4332/
> -----------------------------------------------------------
>
> (Updated 2010-07-21 13:52:16)
>
>
> Review request for kwin and Plasma.
>
>
> Summary
> -------
>
> This patch adds a new KWin effect that allows to modify the appearance of the \
> Plasma dashboard. It has a KCM configuration dialog where you can adjust \
> brightness, saturation and blur of the dashboard background. Blur depends on the \
> loaded blur plugin.
> I also patched the Plasma dashboard to recognize the loaded effect: If the effect \
> is loaded, the dashboard draws its background fully translucent. In order for the \
> Dashboard to recognize wether the effect is loaded, I added support for the effect \
> in Plasma::WindowEffects from kdelibs.
> The dashboard detection in the effect itself is hackish right now. As soon as \
> Plasma adds a proper class to the dashboard window, I will replace the hack with a \
> class-check.
>
> This addresses bugs dashboard, detection and hackish.
> https://bugs.kde.org/show_bug.cgi?id=dashboard
> https://bugs.kde.org/show_bug.cgi?id=detection
> https://bugs.kde.org/show_bug.cgi?id=hackish
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1152500
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION
> trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui \
> PRE-CREATION trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1152500
> trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1152500
> trunk/KDE/kdelibs/plasma/windoweffects.h 1152494
> trunk/KDE/kdelibs/plasma/windoweffects.cpp 1152494
>
> Diff: http://reviewboard.kde.org/r/4332/diff
>
>
> Testing
> -------
>
> Code compiles, plugin loads, plugin configuration dialog is registered in KCM \
> Workspace module under "all effects". If the plugin is enabled, its settings apply \
> to the dashboard.
>
> Screenshots
> -----------
>
> configuration dialog
> http://reviewboard.kde.org/r/4332/s/434/
> dashboard with modified background
> http://reviewboard.kde.org/r/4332/s/435/
>
>
> Thanks,
>
> Andreas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4332/">http://reviewboard.kde.org/r/4332/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>At least for KWin part this is a ship It. If nobody comments on the plasma \
part, just go ahead. Btw there are a few red markings in the diff.</pre> <br />
<p>- Martin</p>
<br />
<p>On July 21st, 2010, 1:52 p.m., Andreas Demmer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Andreas Demmer.</div>
<p style="color: grey;"><i>Updated 2010-07-21 13:52:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds a new KWin effect that allows \
to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog \
where you can adjust brightness, saturation and blur of the dashboard background. \
Blur depends on the loaded blur plugin.
I also patched the Plasma dashboard to recognize the loaded effect: If the effect is \
loaded, the dashboard draws its background fully translucent. In order for the \
Dashboard to recognize wether the effect is loaded, I added support for the effect in \
Plasma::WindowEffects from kdelibs.
The dashboard detection in the effect itself is hackish right now. As soon as Plasma \
adds a proper class to the dashboard window, I will replace the hack with a \
class-check.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Code compiles, plugin loads, plugin \
configuration dialog is registered in KCM Workspace module under "all \
effects". If the plugin is enabled, its settings apply to the dashboard.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=dashboard">dashboard</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=detection">detection</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=hackish">hackish</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1152500)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp <span style="color: \
grey">(1152500)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp <span \
style="color: grey">(1152500)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h <span style="color: \
grey">(1152500)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp <span \
style="color: grey">(1152500)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.h <span style="color: \
grey">(1152494)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.cpp <span style="color: \
grey">(1152494)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4332/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4332/s/434/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_config_400x100.jpeg" \
style="border: 1px black solid;" alt="configuration dialog" /></a>
<a href="http://reviewboard.kde.org/r/4332/s/435/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_400x100.jpeg" \
style="border: 1px black solid;" alt="dashboard with modified background" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic