--===============1922813131== Content-Type: multipart/alternative; boundary="===============1985901662925923055==" --===============1985901662925923055== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/#review6689 ----------------------------------------------------------- Ship it! At least for KWin part this is a ship It. If nobody comments on the plasma = part, just go ahead. Btw there are a few red markings in the diff. - Martin On 2010-07-21 13:52:16, Andreas Demmer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4332/ > ----------------------------------------------------------- > = > (Updated 2010-07-21 13:52:16) > = > = > Review request for kwin and Plasma. > = > = > Summary > ------- > = > This patch adds a new KWin effect that allows to modify the appearance of= the Plasma dashboard. It has a KCM configuration dialog where you can adju= st brightness, saturation and blur of the dashboard background. Blur depend= s on the loaded blur plugin. > = > I also patched the Plasma dashboard to recognize the loaded effect: If th= e effect is loaded, the dashboard draws its background fully translucent. I= n order for the Dashboard to recognize wether the effect is loaded, I added= support for the effect in Plasma::WindowEffects from kdelibs. > = > The dashboard detection in the effect itself is hackish right now. As soo= n as Plasma adds a proper class to the dashboard window, I will replace the= hack with a class-check. > = > = > This addresses bugs dashboard, detection and hackish. > https://bugs.kde.org/show_bug.cgi?id=3Ddashboard > https://bugs.kde.org/show_bug.cgi?id=3Ddetection > https://bugs.kde.org/show_bug.cgi?id=3Dhackish > = > = > Diffs > ----- > = > trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1152500 = > trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1152500 = > trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1152500 = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-C= REATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CR= EATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PR= E-CREATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREA= TION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.des= ktop PRE-CREATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h P= RE-CREATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp= PRE-CREATION = > trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui = PRE-CREATION = > trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1152500 = > trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1152= 500 = > trunk/KDE/kdelibs/plasma/windoweffects.h 1152494 = > trunk/KDE/kdelibs/plasma/windoweffects.cpp 1152494 = > = > Diff: http://reviewboard.kde.org/r/4332/diff > = > = > Testing > ------- > = > Code compiles, plugin loads, plugin configuration dialog is registered in= KCM Workspace module under "all effects". If the plugin is enabled, its se= ttings apply to the dashboard. > = > = > Screenshots > ----------- > = > configuration dialog > http://reviewboard.kde.org/r/4332/s/434/ > dashboard with modified background > http://reviewboard.kde.org/r/4332/s/435/ > = > = > Thanks, > = > Andreas > = > --===============1985901662925923055== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4332/

Ship it!

At least for KWin part this is a ship It. If nobody comments on the p=
lasma part, just go ahead. Btw there are a few red markings in the diff.
 









- Martin






On July 21st, 2010, 1:52 p.m., Andreas Demmer wrote:







 

  


Review request for kwin and Plasma.


By Andreas Demmer.




Updated 2010-07-21 13:52:16






Descripti=
on 



 

  
   
This patch adds a new KWin effect =
that allows to modify the appearance of the Plasma dashboard. It has a KCM =
configuration dialog where you can adjust brightness, saturation and blur o=
f the dashboard background. Blur depends on the loaded blur plugin.

I also patched the Plasma dashboard to recognize the loaded effect: If the =
effect is loaded, the dashboard draws its background fully translucent. In =
order for the Dashboard to recognize wether the effect is loaded, I added s=
upport for the effect in Plasma::WindowEffects from kdelibs.

The dashboard detection in the effect itself is hackish right now. As soon =
as Plasma adds a proper class to the dashboard window, I will replace the h=
ack with a class-check.

  		
 






Testing <=
/h1>


 

  
   
Code compiles, plugin loads, plugi=
n configuration dialog is registered in KCM Workspace module under "al=
l effects". If the plugin is enabled, its settings apply to the dashbo=
ard.

  		
 








 Bugs: 


 dashboard=
, =


 detection=
, =


 hackish







Diffs=
 


    

 
  • trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt (1152500)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp (1152500)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp (1152500)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop <=
span style=3D"color: grey">(PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.de=
sktop (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h =
(PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cp=
p (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui=
 (PRE-CREATION)
    • 

 
  • trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h (1152500)
    • 

 
  • trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp (1152500)
    • 

 
  • trunk/KDE/kdelibs/plasma/windoweffects.h (=
1152494)
    • 

 
  • trunk/KDE/kdelibs/plasma/windoweffects.cpp (1152494)
    • 





View Diff





Screensho=
ts
--===============1985901662925923055==-- --===============1922813131== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1922813131==--