[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fixes for screen hotplugging
From: "Anthony Bryant" <antjbryant () gmail ! com>
Date: 2010-06-25 0:17:45
Message-ID: 20100625001745.17954.30416 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-06-24 17:38:45, Aaron Seigo wrote:
> > looks good; i've committed this patch as it seems you don't have an svn=
account? (if you would like to continue working on these kinds of patches,=
we can hook you up with one)
Thanks! That's right, no svn account yet. I would like to work on plasma mo=
re though, should I request one now or wait until I've done a few more patc=
hes?
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4451/#review6266
-----------------------------------------------------------
On 2010-06-24 15:39:08, Anthony Bryant wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4451/
> -----------------------------------------------------------
> =
> (Updated 2010-06-24 15:39:08)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Aaron's patch almost fixed the problem, but there's still the issue that =
the view is getting created on startup even if its screen does not exist.
> I've added a few checks in createWaitingDesktops() to make sure a view is=
only created if it's for a containment with a valid screen and desktop.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1142286 =
> =
> Diff: http://reviewboard.kde.org/r/4451/diff
> =
> =
> Testing
> -------
> =
> Started plasma with and without an external screen and tried adding and r=
emoving it a few times, with and without per virtual desktop views.
> =
> =
> Thanks,
> =
> Anthony
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4451/">http://reviewboard.kde.org/r/4451/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 24th, 2010, 5:38 p.m., <b>Aaron Seigo</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre>looks good; i've committed this patch as it seems you \
don't have an svn account? (if you would like to continue working on these kinds \
of patches, we can hook you up with one)</pre> </blockquote>
</blockquote>
<pre>Thanks! That's right, no svn account yet. I would like to work on plasma \
more though, should I request one now or wait until I've done a few more \
patches?</pre> <br />
<p>- Anthony</p>
<br />
<p>On June 24th, 2010, 3:39 p.m., Anthony Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>
<p style="color: grey;"><i>Updated 2010-06-24 15:39:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Aaron's patch almost fixed the problem, \
but there's still the issue that the view is getting created on startup even if \
its screen does not exist. I've added a few checks in createWaitingDesktops() to \
make sure a view is only created if it's for a containment with a valid screen \
and desktop.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Started plasma with and without an external \
screen and tried adding and removing it a few times, with and without per virtual \
desktop views.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp <span \
style="color: grey">(1142286)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4451/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic