From kde-panel-devel Fri Jun 25 00:17:45 2010 From: "Anthony Bryant" Date: Fri, 25 Jun 2010 00:17:45 +0000 To: kde-panel-devel Subject: Re: Review Request: Fixes for screen hotplugging Message-Id: <20100625001745.17954.30416 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127742510826458 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1610089040==" --===============1610089040== Content-Type: multipart/alternative; boundary="===============3622222759884457054==" --===============3622222759884457054== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-06-24 17:38:45, Aaron Seigo wrote: > > looks good; i've committed this patch as it seems you don't have an svn= account? (if you would like to continue working on these kinds of patches,= we can hook you up with one) Thanks! That's right, no svn account yet. I would like to work on plasma mo= re though, should I request one now or wait until I've done a few more patc= hes? - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4451/#review6266 ----------------------------------------------------------- On 2010-06-24 15:39:08, Anthony Bryant wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4451/ > ----------------------------------------------------------- > = > (Updated 2010-06-24 15:39:08) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Aaron's patch almost fixed the problem, but there's still the issue that = the view is getting created on startup even if its screen does not exist. > I've added a few checks in createWaitingDesktops() to make sure a view is= only created if it's for a containment with a valid screen and desktop. > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1142286 = > = > Diff: http://reviewboard.kde.org/r/4451/diff > = > = > Testing > ------- > = > Started plasma with and without an external screen and tried adding and r= emoving it a few times, with and without per virtual desktop views. > = > = > Thanks, > = > Anthony > = > --===============3622222759884457054== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4451/

On June 24th, 2010, 5:38 p.m., Aaron Seigo<= /b> wrote:

looks good; i've committed this patch as it seems you don't = have an svn account? (if you would like to continue working on these kinds = of patches, we can hook you up with one)

Thanks! That's right, no svn account yet. I would like to work on = plasma more though, should I request one now or wait until I've done a = few more patches?

- Anthony

On June 24th, 2010, 3:39 p.m., Anthony Bryant wrote:

Review request for Plasma.

By Anthony Bryant.

Updated 2010-06-24 15:39:08

Descripti= on

Aaron's patch almost fixed the= problem, but there's still the issue that the view is getting created = on startup even if its screen does not exist. I've added a few checks in createWaitingDesktops() to make sure a view = is only created if it's for a containment with a valid screen and deskt= op.

Testing <= /h1>

Started plasma with and without an= external screen and tried adding and removing it a few times, with and wit= hout per virtual desktop views.

Diffs=

/trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp (1142286)

View Diff

--===============3622222759884457054==-- --===============1610089040== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1610089040==--