[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-05-25 16:24:44
Message-ID: 201005250924.45249.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On May 22, 2010, Alessandro Diaferia wrote:
> > hmm. no comment on whether it's a feature..  code looks sensible,
> > although wouldn't it be more future-proof to iterate over data->urls()
> > instead of only
> > taking the first?
> 
> you're just right.. so here comes the updated patch :)

looks good with those changes, and a nice usability improvement. please 
commit. 

btw, one additional nice feature to have there would be to make it possible to 
just drag it onto the favourites tab.. but that can wait :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]