[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the
From: Alessandro Diaferia <alediaferia () gmail ! com>
Date: 2010-05-23 8:58:51
Message-ID: AANLkTikczAxKFgA-WqgvaDaZVGzSy2w9x9Y5CQfIVc-b () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2010/5/23 Asraniel <asraniel@fryx.ch>
> I'll just trow that randomly in here.
>
> My gf told me that it would be nice if you could not only mark apps as
> favorites in kickoff, but also stuff like shutdown and especialy "lock
> computer". But i didn't look at the code to see how easely thats possible.
>
> Beat Wolf
>
> Am Samstag 22 Mai 2010, um 18.03:53 schrieb Alessandro Diaferia:
> > Hullo,
> > it seems reviewboard cannot connect to anonsvn (at least from here) so
> i'm
> > attaching the patch here as it is really small.
> >
> > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see
> > how easy is reproducing the bug.
> > It seems that kickoff does not allow adding favorites via D&D. D&D is
> only
> > used to move items in the list.
> > This little patch allows adding favorites via D&D dragging from the
> > application view to the favorites one.
> > I just don't know if this is considered as a new feature. It seems to me
> > that this patch just makes kickoff behaving as it is expected to behave.
> >
> > Anyway the last word is yours of course, plasma-friends :)
> >
> > Regards.
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
It's not so immediate doing such a thing because what we have in the "Leave"
page are leave:/ protocol accessors.
So they're not properly local resources and therefore dragging is not
enableld for them.
Anyway what you suggest feels more like a feature so we should wait for KDE
4.6.
In addition to this probably a little "star" emblem appearing on hover for
each list item would be nice to make that favorite.
IIRC there was a discussion about this in the past.
Just talking about the fix are there any objections for it to be committed?
--
Alessandro Diaferia
KDE Developer
KDE e.V. member
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">2010/5/23 Asraniel <span dir="ltr"><<a \
href="mailto:asraniel@fryx.ch">asraniel@fryx.ch</a>></span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> I'll just trow that randomly in here.<br>
<br>
My gf told me that it would be nice if you could not only mark apps as<br>
favorites in kickoff, but also stuff like shutdown and especialy "lock<br>
computer". But i didn't look at the code to see how easely thats \
possible.<br> <br>
Beat Wolf<br>
<br>
Am Samstag 22 Mai 2010, um 18.03:53 schrieb Alessandro Diaferia:<br>
<div><div></div><div class="h5">> Hullo,<br>
> it seems reviewboard cannot connect to anonsvn (at least from here) so \
i'm<br> > attaching the patch here as it is really small.<br>
><br>
> Having a look at <a href="https://bugs.kde.org/show_bug.cgi?id=231791" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=231791</a> you can see<br> > \
how easy is reproducing the bug.<br> > It seems that kickoff does not allow adding \
favorites via D&D. D&D is only<br> > used to move items in the list.<br>
> This little patch allows adding favorites via D&D dragging from the<br>
> application view to the favorites one.<br>
> I just don't know if this is considered as a new feature. It seems to me<br>
> that this patch just makes kickoff behaving as it is expected to behave.<br>
><br>
> Anyway the last word is yours of course, plasma-friends :)<br>
><br>
> Regards.<br>
<br>
</div></div><div><div></div><div \
class="h5">_______________________________________________<br> Plasma-devel mailing \
list<br> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br><br clear="all">It's not so immediate doing \
such a thing because what we have in the "Leave" page are leave:/ protocol \
accessors.<br>So they're not properly local resources and therefore dragging is \
not enableld for them.<br> Anyway what you suggest feels more like a feature so we \
should wait for KDE 4.6.<br>In addition to this probably a little "star" \
emblem appearing on hover for each list item would be nice to make that favorite.<br> \
IIRC there was a discussion about this in the past.<br><br>Just talking about the fix \
are there any objections for it to be committed?<br>-- <br>Alessandro Diaferia<br>KDE \
Developer<br>KDE e.V. member<br><br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic