From kde-panel-devel Tue May 25 16:24:44 2010 From: "Aaron J. Seigo" Date: Tue, 25 May 2010 16:24:44 +0000 To: kde-panel-devel Subject: Re: [PATCH] Fix kickof bug 231791 allowing apps dropping in the Message-Id: <201005250924.45249.aseigo () kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127480473215233 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0110643237==" --===============0110643237== Content-Type: multipart/signed; boundary="nextPart2714421.b8cLB1JBOk"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart2714421.b8cLB1JBOk Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On May 22, 2010, Alessandro Diaferia wrote: > > hmm. no comment on whether it's a feature.. code looks sensible, > > although wouldn't it be more future-proof to iterate over data->urls() > > instead of only > > taking the first? >=20 > you're just right.. so here comes the updated patch :) looks good with those changes, and a nice usability improvement. please=20 commit.=20 btw, one additional nice feature to have there would be to make it possible= to=20 just drag it onto the favourites tab.. but that can wait :) =2D-=20 Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks --nextPart2714421.b8cLB1JBOk Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) iEYEABECAAYFAkv7+c0ACgkQ1rcusafx20OnmwCfQ5k8FKmLUoUtHSbnL3WY1A54 qLEAoJLflf5OrmY8x7iNkU5eEZ/j70Y9 =rP1+ -----END PGP SIGNATURE----- --nextPart2714421.b8cLB1JBOk-- --===============0110643237== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0110643237==--